Breaking CSS url()

Resolved James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

Hello @patrickposner! Hope you’re well.

Longtime happy pro user here.

My CSS input to SimplyStatic contains SVG via CSS url(). This SVG, as is standard, contains the xmlns attribute, with a value that contains http://, but SS trims the second slash down to http:/ and the svg breaks.

The issue does not occur on WP, only on static output.

Note that I do not have any SS code optimization features toggled on.

Note also that this is not deterministic. It occurs on some url() but not others, and I am not discerning a pattern to this issue. I tried pasting the complete CSS, but the SVG gets sanitized.

Viewing 10 replies - 1 through 10 (of 10 total)

Plugin Author patrickposner
(@patrickposner)

1 week, 3 days ago

Hey @jamesjosephfinn,

happy to look into that!

Could you paste the full CSS in something like a Gist on GitHub or send the it directly to support@simplystatic.com?

Without it, it’s probably hard to track down 😅

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

Here you go, sir! Gists

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

Searching for background-image will surface the disparity straight away.

Plugin Author patrickposner
(@patrickposner)

1 week, 3 days ago

@jamesjosephfinn, great!

I wrote a small fix here: https://github.com/Simply-Static/simply-static/commit/6266e30f826a0c0659655c5e1c1deb1a260a481e#diff-ee9b14e40d7172b0e4f2bc6f614cfcadec282c85544d24742350bdcbc9d53cce

You might want to download and test this file from here: https://github.com/Simply-Static/simply-static/blob/master/src/class-ss-url-extractor.php (it already includes the patch), but given the 24-hour delay for every release right now on w.org – we might want to confirm that before I push that into an official update! 😅

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

Ah! Regex to blame; no surprise there! I’m running a “full export” now, which currently takes ~23 mins. I’ll reply back in about an hour!

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

The issue resolved in that file, but introduced a new issue with a different CSS file, where the outputted CSS file is literally empty.

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 3 days ago

Here’s the input if you’re curious: gist

Plugin Author patrickposner
(@patrickposner)

1 week, 1 day ago

@jamesjosephfinn that was helpful!

I got another patch in (yes, even more regex fine-tuning.. 😅): https://github.com/Simply-Static/simply-static/commit/e01c3ab99991ac3b7eaa7b0fcaedb2870c079789

Updated file: https://github.com/Simply-Static/simply-static/blob/master/src/class-ss-url-extractor.php

Thread Starter James Joseph Finn
(@jamesjosephfinn)

1 week, 1 day ago

@patrickposner you are an upstanding gentleman and magnanimous scholar! All visual regressions have been restored to their prior working state.

Thanks for all you do for WP! SS is a critical dependency in our infrastructure pipeline, and we trust that the project is in good hands.

Plugin Author patrickposner
(@patrickposner)

1 week ago

@jamesjosephfinn Thanks for confirming!

I guess all those hours that we invest in automated test coverage are finally paying off – much easier these days to get this fixed and continuously track that they don’t happen again!

I’ll wrap this into an official release alongside a few other improvements – so it should be safe for you to update on Monday!

Viewing 10 replies - 1 through 10 (of 10 total)

You must be logged in to reply to this topic.