Braking Change with {validation_link}?

  • Resolved dtreplin

    (@dtreplin)


    2 months, 2 weeks ago

    Hi,

    up to march 15, I had in my confirmation E-Mail the following code, working just fine:

    <a href="{validation_link}">Confirm your application</a>

    Some days later all links in newly generated emails were broken because {validation_link} now contains the full html code for the link. I neither like the new behaviour (cannot set the link text myself) nor do I like breaking changes in automated updates – It caused nested links and these dont work, causing a lot of trouble and angry volunteers (and the lack of, as a consequence).

    How can I get back to the old behaviour and how can I make sure the next update will not make my vounteers angry again?

    Daniel

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author DBAR Productions

    (@dbar-productions)

    2 months, 2 weeks ago

    I’m in Ecuador on vacation with extremely limited internet access and only my phone until the 25th. So, I can’t change anything.

    Sorry you don’t like the plugin. It’s open source and you can either download previous versions from Github, or feel free to fork your own branch and change the code any way you like. Very easy to do with any AI agent these days. Then you can disable automatic updates if you don’t want any further changes.

    Thread Starter dtreplin

    (@dtreplin)

    2 months, 2 weeks ago

    Dont get me wrong, I LOVE the plugin, I even depend on it organising volunteer hours for around 650 members in my finshing club and my sailing club. I only beg you: be carefull with breaking changes, better create a new variable if the content changes fundamentally. I fixed this in less than an minute, but it caused trouble until I noticed. The approval link in the email was not clickable anymore, but still highlighted as a link. So my vounteers clicked, but did not notice the malfunction and got kicked out of their assignements 24 hours later. Then their assigned places were taken by others. This caused a lot ot irritation.
    Stopping automated updates indeed might be a good idea nowadays, regarding the staggering number af supply chain attacks to repositories and even hostile takeovers of wordpress plugins.

    Enjoy your holiday!
    Daniel

    Plugin Support stephensherrard

    (@stephensherrard)

    2 months, 2 weeks ago

    Now wordpress.org won’t let me reply from my main account because of a more strict branded account policy.

    I think at one point when implementing the newer consolidated template tag class and functions we added some code to make any URLs clickable if you have emails set to HTML. Not intending to break anything, as I didn’t think about the case of people trying to make their own clickable links from the raw URL. So far, you’re the only one who has reported this as an issue. Usually if I have added a new feature that could change existing behavior, I have made a new option you need to use to enable the feature, so that it doesn’t affect existing sites.

    When I return I will add a new option to disable the automatic URL encoding.

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.