Bad Code ahead

  • solarbaypilot

    (@solarbaypilot)


    8 years, 5 months ago

    After default installation we get the following errors (PHP notices) on the registration page:

    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 147
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/classes/registration_form.php on line 145
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 165
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 165
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 165
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 183
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 183
    Notice: Undefined index: validation_message in /wp-content/plugins/pie-register/pie_register_template/registration/registration_form_template.php on line 183

    This is a proof for bad coding practice. Please learn to code PHP well before placing a plugin in marketplace!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Contributor genetech

    (@genetech)

    8 years, 5 months ago

    Hi,

    Sorry for the inconvenience caused by the warnings being displayed to you. Please note that this plugin was originally built over 8 years ago and since then there have been many upgrades and feature enhancements which make the plugin worth using. We have traveled a long way since and such issues have been fixed throughout the plugin. However there could be some issues which are identified by our team as well as by PR users and are fixed accordingly. Giving a 1 star for some warnings being shown isn’t that just and I hope that you will like the plugin overall and will adjust the rating accordingly. Meanwhile we have added the warnings to you mentioned to our backlog and will be fixed with our next version expected in 1-2 weeks.

    Also to report an issue, you can use our forum at https://pieregister.com/forum/

    Thanks,
    Team PR

    Thread Starter solarbaypilot

    (@solarbaypilot)

    8 years, 5 months ago

    I’m sorry for the harsh voting on your plugin but I have strong opinions about code quality.
    Also 8 years ago you could already develop with PHP option error_reporting(E_ALL) set and always check if a variable (or a key of a property) isset in the first place. In other languages this error would most likely not only cause a notice but throw a null pointer exception.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Bad Code ahead’ is closed to new replies.