Bad

  • tekap33

    (@tekap33)


    9 years, 2 months ago

    It seems to be a bad implementation of an other plugin.

    Doesn’t work with child theme.
    Uses inline-code and overrides Child Theme style.css.
    Doesn’t find translation files for it is searching text-domain kirki.

    Most of the code is (inc/libraries/kirki)

    * Plugin Name: Kirki Toolkit
    * Plugin URI: http://kirki.org
    * Description: The ultimate WordPress Customizer Toolkit
    * Author: Aristeides Stathopoulos
    * Author URI: http://aristeides.com
    * Version: 2.3.7
    * Text Domain: kirki

Viewing 4 replies - 1 through 4 (of 4 total)
  • Ari Stathopoulos

    (@aristath)

    9 years, 2 months ago

    Hey there!

    It seems to be a bad implementation of an other plugin.

    If I may ask which plugin might that be? I personally wrote every single line of code in Kirki an it has taken me more than 2.5 years. So this is definitely not an implementation -good or bad- of any other plugin

    Doesn’t work with child theme.

    If works 100% with child themes! What is it that you couldn’t get to work?

    Uses inline-code and overrides Child Theme style.css.

    That depends on the implementation of whoever implements it… Kirki has options to add inline code, you can change the priority of the styles so they are added before or after your child theme, you can use the alternative AJAX method for loading the styles, or you can even disable the included methods and add your own compiler.
    Kirki doesn’t make any assumptions and it’s up to the developer using it to do what’s best for their use-case.

    Doesn’t find translation files for it is searching text-domain kirki.

    Again, this is up to the developer using it.
    We provide filters that allow developers to change the textdomains and use whatever they want: https://github.com/aristath/kirki/blob/2.3.7/includes/class-kirki-l10n.php#L226

    Thread Starter tekap33

    (@tekap33)

    9 years, 2 months ago

    @aristath

    Please read my posting about Advanced Twenty Seventeen once more.

    I didn’t critizise your plugin Kirki under no circumstances.

    It seems to be a bad implementation of an other plugin.
    Uses inline-code and overrides Child Theme style.css.
    Doesn’t find translation files for it is searching text-domain kirki.
    concern only the plugin Advanced Twenty Seventeen.

    Your post

    That depends on the implementation of whoever implements it

    and it’s up to the developer using it to do what’s best for their use-case.

    is exactly what I say,

    Advanced Twenty Seventeen is a bad implementation of an other plugin named Kirki.

    regards
    tekap33

    • This reply was modified 9 years, 2 months ago by tekap33.
    DBJ

    (@dbj)

    9 years, 2 months ago

    http://kirki.org is not a plugin

    Ari Stathopoulos

    (@aristath)

    9 years ago

    @tekap33 My apologies…
    I get notifications on my mail whenever kirki is mentioned in wordpress.org and I didn’t see that it was posted elsewhere

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Bad’ is closed to new replies.