Background doesn't disappear if "close on conversion" = no

  • Resolved zef32

    (@zef32)


    11 years, 2 months ago

    Hi there. Fantastic plugin, I can style the box to my liking, embedding contact form shortcode, and have it display on basis of height instead of time.

    I may have found a bug however – when I set the “close on conversion” option to no, after clicking the submit button (on the popop form), the popup goes away but the overlay background does not, basically rendering the webpage useless and forcing the user to refresh.

    I’m looking through the javascript if I can find and solve the problem myself, but given how talented the author is, I’m sure they’ll snatch the bug much much quicker? Please do let me know if you have a solution, whatever it may be.

    https://wordpress.org/plugins/popups/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter zef32

    (@zef32)

    11 years, 2 months ago

    Fixed! : )

    At first I thought it was the missing ‘0’ data attribute for data-close-on-conversion (line 65, public/views/popup.php), but that didn’t work. Of course, why would it? An empty string is as good as a boolean false.

    So then it was line 430 in public.js The elseif condition should also be taking the variable ‘conversion’ into consideration.. just like for $box a couple lines above! So I replaced line 430 with this:

    } else if (show === false && ( (conversion_close && conversion ) || !conversion ) ) {

    ..and now it works just dandy. : ) Of course, I’ll have to re-generate the minified file for production use…

    Please do incorporate this bug into your next update. : )

    Plugin Author Damian

    (@timersys)

    11 years, 2 months ago

    Hi Zef thanks for pointing that out! I added the fix for next version.

    Regards

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Background doesn't disappear if "close on conversion" = no’ is closed to new replies.