Dear Alwyn,
I don’t see why not, and I think I should be able to replicate it. Just to confirm my understanding, when the Audio Health check finds a link stored as http://, you’d like it to actually try that http:// version before reporting the audio as missing — rather than treating it as broken because the site has since moved to https. Is that right?
Could you also confirm a couple of things. Are your sermon audio files already hosted on your own server (rather than linked from somewhere external), and do they appear in your Media library? That’ll tell me where to start looking.
Please don’t go changing anything yet. I’ll let you know one way or the other by the weekend.
Best wishes,
Mattytap
Yes, Audio Health should be ok with urls that have the old http:// because the player will still play them without a problem, at least for sermon files held locally (which is where our historic sound files are held), even though Audio Health reports them as being missing.
Our sermon files are not necessarily held in our media library directly; most are held in a subdirectory of the media library called ‘sermons’. But they are all held locally. The full URL is used, I guess, because the person uploading them just used the URL that refers to the file directly from off-site.
We don’t have external links for older content, and all newer content on YouTube will already use https. So, sadly, I can’t test external links. However, I suspect that external links will still work because most browsers will ‘upgrade’ from http to https for external links.
Thanks for looking at this.
If we have to, I guess we could do an update to all entries, but it is literally many hundreds – everything between 2008 and mid 2017.
-
This reply was modified 1 week, 5 days ago by
Alwyn Barry.
I was pondering overnight on the Audio Health feature. We run a link checker plugin to detect failed site links. Is Audio health doing the same thing? I haven’t checked how the link checker works, and it may only be looking in posts, rather than custom fields.
I only mention this so that a new feature which may be covered by other plugins doesn’t take up your time and effort. On face value it seems like an excellent addition, but it may be worth checking if it might be covered by other solutions.
Thank you again for all your work on this plugin.
Hello,
Ive made and tested the changes. it was a trivial change, four lines of code. Download 3.4 or wait until it auto-updates in 24 hours time.
Thanks for making that change – amazing!
Just to confirm that Broken Link Checker (https://en-gb.wordpress.org/plugins/broken-link-checker/) that we use does also have a config to check into sermons and custom fields, but it would take a bit of configuring which is maybe beyond the usual user. So, having the Audio Checker is really useful.
Thanks Alwyn
this is now fixed in 3.4.0. The Audio Health report now matches a local audio file whether the stored URL is http:// or https://, so audio saved before an SSL move is no longer wrongly listed as missing. Genuinely missing files are still reported. Update to the latest version and it should clear.
Best Wishes
Mattytap
