afterpay.js duplicate display keys in object

  • Resolved launchinteractive

    (@launchinteractive)


    6 years, 5 months ago

    I think there is an error in afterpay.js with this code:

    $popup_outer = $(document.createElement('div'))
				.attr('id', 'afterpay-popup-outer')
				.css({
					'display': '-ms-flexbox',
					'display': '-webkit-flex',
					'display': 'flex',
					'-webkit-justify-content': 'center',
					'-ms-flex-pack': 'center',
					'justify-content': 'center',
					'-webkit-align-content': 'center',
					'-ms-flex-line-pack': 'center',
					'align-content': 'center',
					'-webkit-align-items': 'center',
					'-ms-flex-align': 'center',
					'align-items': 'center',
					'width': '100%',
					'min-height': '100%',
					'background-color': 'rgba(0, 0, 0, 0.80)'
				})
				.appendTo($popup_wrapper);

    This fails to compress with google closure because of the duplicate display keys. I don’t think -ms-flexbox and -webkit-flex is really required anymore.

Viewing 1 replies (of 1 total)
  • Plugin Author Afterpay

    (@afterpayit)

    6 years, 5 months ago

    Hi @launchinteractive,

    Thank you for your message. This information has been forwarded to the development team for further investigation and discussion. Preliminary investigation has suggested that this JavaScript was ported from the CSS file where multiple values for “display” are permitted. In future, the vendor prefixes will likely be removed from this JavaScript as you have suggested, since jQuery has apparently handled these prefixes automatically since version 1.8.0.

    Any subsequent updates to the Afterpay Gateway for WooCommerce plugin will be distributed via the official WordPress Plugin Directory.

    Thank you.

Viewing 1 replies (of 1 total)

The topic ‘afterpay.js duplicate display keys in object’ is closed to new replies.