add_filter() logic parenthesis

Roland, I followed you suggestion and enabled debug mode. Here is an example of the query that was generated after applying filter for list view.

PDb_List::_setup_iteration list query: SELECT p.id, p.full_name, p.qualification, p.work_country, p.wage, p.country, p.native_language, p.additional_languages, p.details FROM wp_participants_database p WHERE (p.role = “user” AND p.approved = “yes” AND p.work_country LIKE “%Austria%” AND p.user_login = “2@mail.com”) OR p.user_login = “1@mail.com” ORDER BY p.date_updated DESC

so, this part comes from the shortcode

this part is from filter form

and the last part

was added in action ‘pdb-list_query_object’ I was talking about in previous post.

As you can see first value of custom filter goes in parenthesis with the filter from the form, I was expecting to see something like this:

SELECT p.id, p.full_name, p.qualification, p.work_country, p.wage, p.country, p.native_language, p.additional_languages, p.details FROM wp_participants_database p WHERE p.role = “user” AND p.approved = “yes” AND p.work_country LIKE “%Austria%” AND (p.user_login = “2@mail.com” OR p.user_login = “1@mail.com”) ORDER BY p.date_updated DESC

P.S. “Enable Filter Mode” option is ON, and always was

• This reply was modified 6 years, 8 months ago by exc1usive.
• This reply was modified 6 years, 8 months ago by exc1usive.
• This reply was modified 6 years, 8 months ago by exc1usive.

I’m using theme’s page template to display the list. It has some logic in php and html markup. Since I put the shortcode in php, I have to use echo do_shortcode(…); function.

But, the issue lies somewhere else. I simplified everything by removing the usage of templates, but the problem is still there.
So, here are the steps to reproduce the problem:

1. I created blank page and placed shortcode [pdb_list template=multisearch] directly to its content. No php, no html, no templates this time.
2. In my functions.php, I removed all unnecessary logic and the loop where i altered the query list object, and just used constants in action, like this:

function filter_by_avalability_dates($query_filter) {
    $query_filter->add_filter('user_login', '=', '2@mail.com', 'OR');
    $query_filter->add_filter('user_login', '=', '1@mail.com', 'OR');
}
add_action('pdb-list_query_object', 'filter_by_avalability_dates');

That is it! Now, on my search form I set filter for only one field, any field, and have this result in my debug log.
(just where portion of the query)

WHERE (p.work_country LIKE "%Austria%" AND p.user_login = "2@mail.com") OR p.user_login = "1@mail.com"

The expected result would be:
WHERE p.work_country LIKE "%Austria%" AND (p.user_login = "2@mail.com" OR p.user_login = "1@mail.com")

See the difference? I don’t know how you might have different result in your tests? I definitely doing something wrong.
If I change OR to AND for the first value (only for an experiment):

function filter_by_avalability_dates($query_filter) {
    $query_filter->add_filter('user_login', '=', '2@mail.com', 'AND');
    $query_filter->add_filter('user_login', '=', '1@mail.com', 'OR');
}
add_action('pdb-list_query_object', 'filter_by_avalability_dates');

The query would be
WHERE (p.work_country LIKE "%Austria%" AND p.user_login = "2@mail.com" AND p.user_login = "1@mail.com")

As you can see, in parenthesis goes only expressions joined using AND. I would like to put parenthesis around ORs.

No, I don’t mess with the pdb-list_query_parens_logic filter in my code.
But, after you told me about its existence, I added following lines to my functions.php file.

function ff_parenthesize_or_statements()
{
	return true;
}
add_filter( 'pdb-list_query_parens_logic', 'ff_parenthesize_or_statements' );

Not sure if it’s the right way of using it. But it didn’t change the query, the parenthesis are still around AND statements.

What else can I try to find the origin of this behavior?

Yes, indeed! But, I don’t set the values for those search fields during this experiment, they are just left out blank.

Great! Thanks a lot!