Search result

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter abonnefoy

    (@abonnefoy)

    10 years, 11 months ago

    I checked code. i think it’s comming from
    templates\templates-functions.php

    function override_product_page_title( $page_title, $id = null ) {
	if ( !is_admin() && is_ic_catalog_page() && !is_ic_product_page() && !in_the_loop() && (empty( $id ) || (get_quasi_post_type( get_post_type( $id ) ) == 'al_product')) ) {

    is_ic_product_page() is called twice in if statement, with and without “!”.
    I will never enter in 🙂

    2nd remark, why checking is_asdmin? admin will also be glad to see search result for .. 🙂

    Then, I this is my correction:

    function override_product_page_title( $page_title, $id = null ) {
	if ( !is_ic_product_page() && !in_the_loop() && (empty( $id ) || (get_quasi_post_type( get_post_type( $id ) ) == 'al_product')) ) {

    Plugin Author ndre

    (@ndre)

    10 years, 11 months ago

    Thanks for reporting it. Unfortunately I couldn’t replicate this error on our test servers.

    As I can see it shows up nicely on your website too.

    It is actually not calling is_ic_product_page twice. Please see it carefully in your example 🙂

    You can see the is_admin function in codex. It will explain why it is used there.

    Can you confrim that the problem persists in 2.2.11?

    Thread Starter abonnefoy

    (@abonnefoy)

    10 years, 11 months ago

    Hello
    I updated it this morning. Isuue ils still present
    http://gateaux.bonnefoy.eu/?s=mac&post_type=al_product

    I fixed issue with path from m’y previous reply. Thats why it was working when you checked.
    You van recheck now. I didn.t apply patch.

    Thanks

    Thread Starter abonnefoy

    (@abonnefoy)

    10 years, 11 months ago

    Hello,

    I was able to recheck, you was right. 1rst code was a bad copy paste..
    This is the “real” code:

    function override_product_page_title( $page_title, $id = null ) {
	if ( !is_admin() && is_ic_catalog_page() && !is_ic_product_page() && !in_the_loop() && (empty( $id ) || (get_quasi_post_type( get_post_type( $id ) ) == 'al_product')) ) {
		$archive_names = get_archive_names();

    I think issue is anyway coming from is_ic_catalog_page() witch is returning false on this search page.

    If I add “!”, it’s working again..
    if ( !is_admin() && !is_ic_catalog_page() &&

    Last, thanks for is_admin() link. Got it.

    Plugin Author ndre

    (@ndre)

    10 years, 11 months ago

    Yes it’s comming from is_ic_catalog_page() when the product listing is disabled.

    It will be fixed in the next version.

    Thank you for reporting it!

    Thread Starter abonnefoy

    (@abonnefoy)

    10 years, 11 months ago

    thanks. do you know when will be this next release?

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Search result’ is closed to new replies.