plugin use creates malformed html with version 3.7.1
-
The recent release of wp version 3.7.1 is not playing well with this plugin.
While the d3.js renders it’s code, there is a failure somewhere internally that corrupts some html code that is causing issues.I understand the source of the issue is the same as that described and resolved for yoast, who posted code to sort it out here:
https://github.com/jrfnl/wordpress-seo/commit/6fe5d7919349774203aac0230ce8797a9cf95789
It seems that a change to wordpress function calls mean plugin code may need updating. I’d love to use d3.js on my site. Any chance this can be looked at?
thank you
-
Hi,
what HMTL issues are you finding exactly?
I have tested wp-d3 with my test pages in WP 3.7.1 and they seem to work fine.Ruben.
Hi Ruben, thanks for getting back to me, and thanks for putting a great plugin together.
Somewhere there is an issue where a variable creating html, or regex applied to the html is mangling the output. I only see it when activating the wp-d3 plugin. It caused a line to be included where the domain is malformed, showing the co.uk as co.uk1?, which in turn causes timeout issues.
The output html with the error is:
<script type='text/javascript' src='http://www.byte.hg.co.uk1?ver=3.7.1'></script>where the uk1 should possibly have been something included:
http://www.byte.hg.co.uk/somedir/something.js?ver=3.7.1When I disable the plugin it returns to good html, and the offending line is no longer there, example of correct html when plugin off below:
<!--[if lt IE 9]> <link href="http://www.byte.hg.co.uk/wp-content/themes/canvas/css/non-responsive.css" rel="stylesheet" type="text/css" /> <style type="text/css">.col-full, #wrapper { width: 1020px; max-width: 1020px; } #inner-wrapper { padding: 0; } body.full-width #header, #nav-container, body.full-width #content, body.full-width #footer-widgets, body.full-width #footer { padding-left: 0; padding-right: 0; } body.fixed-mobile #top, body.fixed-mobile #header-container, body.fixed-mobile #footer-container, body.fixed-mobile #nav-container, body.fixed-mobile #footer-widgets-container { min-width: 1020px; padding: 0 1em; } body.full-width #content { width: auto; padding: 0 1em;}</style> <![endif]--> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-includes/js/comment-reply.min.js?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-includes/js/jquery/jquery.js?ver=1.10.2'></script>I enclose a dump of the raw html wrapping the error for review.
<!-- / Yoast WordPress SEO plugin. --> <link rel="alternate" type="application/rss+xml" title="byte Limited » Feed" href="http://www.byte.hg.co.uk/feed" /> <link rel="alternate" type="application/rss+xml" title="byte Limited » Comments Feed" href="http://www.byte.hg.co.uk/comments/feed" /> <link rel="alternate" type="application/rss+xml" title="byte Limited » Testing Vida.io Comments Feed" href="http://www.byte.hg.co.uk/dataviz/2013/11/testing-vida-io/feed" /> <style type="text/css"> @media only screen and (min-width: 768px) { body.two-col-left-1020 #main-sidebar-container { width: 100%; } body.two-col-left-1020 #main-sidebar-container #sidebar { width: 28.385%; } body.two-col-left-1020 #main-sidebar-container #main { width: 68.385%; } } </style> <link rel='stylesheet' id='images-responsive-thumbnail-slider-style-css' href='http://www.byte.hg.co.uk/wp-content/plugins/wp-responsive-thumbnail-slider/css/images-responsive-thumbnail-slider-style.css?ver=3.7.1' type='text/css' media='all' /> <link rel='stylesheet' id='woodojo-social-widgets-css' href='http://www.byte.hg.co.uk/wp-content/plugins/woodojo/bundled/woodojo-social-widgets/assets/css/style.css?ver=3.7.1' type='text/css' media='all' /> <link rel='stylesheet' id='theme-stylesheet-css' href='http://www.byte.hg.co.uk/wp-content/themes/andrews-byte-childtheme/style.css?ver=5.2.0' type='text/css' media='all' /> <link rel='stylesheet' id='woo-layout-css' href='http://www.byte.hg.co.uk/wp-content/themes/canvas/css/layout.css?ver=3.7.1' type='text/css' media='all' /> <!--[if lt IE 9]> <link href="http://www.byte.hg.co.uk/wp-content/themes/canvas/css/non-responsive.css" rel="stylesheet" type="text/css" /> <style type="text/css">.col-full, #wrapper { width: 1020px; max-width: 1020px; } #inner-wrapper { padding: 0; } body.full-width #header, #nav-container, body.full-width #content, body.full-width #footer-widgets, body.full-width #footer { padding-left: 0; padding-right: 0; } body.fixed-mobile #top, body.fixed-mobile #header-container, body.fixed-mobile #footer-container, body.fixed-mobile #nav-container, body.fixed-mobile #footer-widgets-container { min-width: 1020px; padding: 0 1em; } body.full-width #content { width: auto; padding: 0 1em;}</style> <![endif]--> <script type='text/javascript' src='http://www.byte.hg.co.uk1?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-includes/js/comment-reply.min.js?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-includes/js/jquery/jquery.js?ver=1.10.2'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-includes/js/jquery/jquery-migrate.min.js?ver=1.2.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-content/plugins/wp-responsive-thumbnail-slider/js/images-responsive-thumbnail-slider-jc.js?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-content/themes/canvas/includes/js/third-party.js?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-content/themes/canvas/includes/js/modernizr.js?ver=2.6.2'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-content/themes/canvas/includes/js/jquery.flexslider.min.js?ver=3.7.1'></script> <script type='text/javascript' src='http://www.byte.hg.co.uk/wp-content/themes/canvas/includes/js/general.js?ver=3.7.1'></script> <!-- Adjust the website width -->hope that explains it in more detail.
thanks
AndrewHi,
I wish all issues had such a detailed debug as yours ;-).
I managed to find where the problem was and it has been fixed in the plugin’s version I’ve just shipped.Thanks for your feedback!
Rubén.
Thank you Rubén, that is great. I will retest and post here confirmation all is good.
Best regards, AndrewI retested it and the error is now fixed. Nice work.
Thanks again.
AI am also having an issue with the plugin causing issues with my theme. I’m using the latest version of Divi theme which is more of a GUI page builder than a theme.
Every time I activate the plugin it causes gaps between all of my modules (divs) and screws with the overall width somehow causing everything to be too wide somehow and knocking my columns out of place.
The topic ‘plugin use creates malformed html with version 3.7.1’ is closed to new replies.