Not for developers

  • Mário Valney

    (@mariovalney)


    7 years, 7 months ago

    Maybe it works “fine” with themes built for that. But it’s definitely not for developers.

    The plugin rewrite unnecessarily URLs like /courses and /courses/category making unvalid requests with “page_id=-1” wich seems to break a lot of native stuff. For example, is_post_type_archive( 'course' ) is returning false in archive-course.php and native Loop don’t show any course.

    More tests are required but I think a plugin should runs smoothly with WordPress paradigma.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support Imran – WPMU DEV Support

    (@wpmudev-support9)

    7 years, 7 months ago

    Hello @mariovalney

    We appreciate the time of writing your review to us. And yes, the is_post_type_archive( 'course' ) is returning false, which is fixed in version 3.0 which will be released in the close future. Although it is not breaking anything. Those rewrites are used to show courses and courses categories.

    Please let us know exactly what native stuff has been broken on your site?

    Please advise,

    Kind regards,
    Nastia

    Thread Starter Mário Valney

    (@mariovalney)

    7 years, 7 months ago

    Those rewrites are used to show courses and courses categories.

    For courses, for example, it’s not necessary as WordPress already support rewrite slug in Custom Post Types and Taxonomies.

    Anyway… Until now, I faced:

    • “body_class” is not consistent with WP in category page
    • Cannot use taxonomy-course_category.php template because CP override templates
    • Main query in arquive-course.php seems not work because it’s default for CP pages
    Plugin Support Dimitris – WPMU DEV Support

    (@wpmudev-support6)

    7 years, 7 months ago

    Really appreciate the feedback on this @mariovalney 🙂

    I’ve already forwarded this to our developers for further consideration.

    Take care,
    Dimitris

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Not for developers’ is closed to new replies.