Forum Replies Created

Viewing 14 replies - 16 through 29 (of 29 total)
  • Thread Starter woomigrating

    (@woomigrating)

    1. You’re right, I only use the AO LazyLoad and not the AO/SP CDN on the fly image optimization.

    3. CAOS support said they don’t let analytics.js aggregate “since the file contains variable names of one character: ‘b’ for example, combining it with other js files could cause the wrong variable to be called”

    Do you agree that would cause issues if aggregated into AO js, or is it worth a shot trying?

    5. There was some error message in top of page when I submitted the message on Frank blog. I’ll send it on your gmail!

    Thread Starter woomigrating

    (@woomigrating)

    Could not have img element in post so changed to imge
    With Shorpixel webp – without AO LazyLoading

    
    <picture width="324" height="324" class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail sp-no-webp">
    <source srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.webp 324w,https://www.mysite.com/wp-content/uploads/myimage-150x150.webp 150w,https://www.mysite.com/wp-content/uploads/myimage-300x300.webp 300w,https://www.mysite.com/wp-content/uploads/myimage-416x416.webp 416w,https://www.mysite.com/wp-content/uploads/myimage-100x100.webp 100w,https://www.mysite.com/wp-content/uploads/myimage.webp 600w" sizes="(max-width: 324px) 100vw, 324px" type="image/webp">
    <source srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" sizes="(max-width: 324px) 100vw, 324px">
    <imge src="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg" width="324" height="324" class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail sp-no-webp" alt="My Image" srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" sizes="(max-width: 324px) 100vw, 324px">
    </picture>
    
    With Shorpixel webp and AO LazyLoading
    
    <picture width="324" height="324" class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail sp-no-webp lazyloaded" data-srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w">
    <source data-srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.webp 324w,https://www.mysite.com/wp-content/uploads/myimage-150x150.webp 150w,https://www.mysite.com/wp-content/uploads/myimage-300x300.webp 300w,https://www.mysite.com/wp-content/uploads/myimage-416x416.webp 416w,https://www.mysite.com/wp-content/uploads/myimage-100x100.webp 100w,https://www.mysite.com/wp-content/uploads/myimage.webp 600w" sizes="(max-width: 324px) 100vw, 324px" type="image/webp" srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.webp 324w,https://www.mysite.com/wp-content/uploads/myimage-150x150.webp 150w,https://www.mysite.com/wp-content/uploads/myimage-300x300.webp 300w,https://www.mysite.com/wp-content/uploads/myimage-416x416.webp 416w,https://www.mysite.com/wp-content/uploads/myimage-100x100.webp 100w,https://www.mysite.com/wp-content/uploads/myimage.webp 600w">
    <source data-srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" sizes="(max-width: 324px) 100vw, 324px" srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w">
    <imge data-src="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg" width="324" height="324" class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail sp-no-webp lazyloaded" data-srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" alt="My image" srcset="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg 324w, https://www.mysite.com/wp-content/uploads/myimage-150x150.jpg 150w, https://www.mysite.com/wp-content/uploads/myimage-300x300.jpg 300w, https://www.mysite.com/wp-content/uploads/myimage-416x416.jpg 416w, https://www.mysite.com/wp-content/uploads/myimage-100x100.jpg 100w, https://www.mysite.com/wp-content/uploads/myimage.jpg 600w" sizes="(max-width: 324px) 100vw, 324px" src="https://www.mysite.com/wp-content/uploads/myimage-324x324.jpg">
    </picture>
    
    • This reply was modified 7 years, 2 months ago by James Huff.
    • This reply was modified 7 years, 2 months ago by Jan Dembowski. Reason: Fixed formatting
    Thread Starter woomigrating

    (@woomigrating)

    1. It also acts on <picture and also on the two <source

    <picture – adds: srcset + data-srcset
    <source (webp) – adds: data-srcset
    <source (jpg) – adds: data-srcset
    <img – adds: data-src + data-srcset

    I’ll paste the output in the comment below for your reference.

    2. Thanks, tried it, but PageSpeed gave me worse score so I guess I’ll better leave it non-optimized.

    3. I’ll check!

    4. Hope there will be a solution, soonish 😉

    5. I’ve contacted you through the contact form on Frank blog regarding this!

    Thread Starter woomigrating

    (@woomigrating)

    Hawing multiple staging environments, testing different solutions, might have gotten me mixing it all up. Your filter very possibly didn’t work before either, but now it indeed does work!

    Thanks 🙂

    Thread Starter woomigrating

    (@woomigrating)

    Thank you, this worked until your last plugin update. Now the pop-up keep popping up with each page load (after the 5s sleep).
    When disabling this filter the pop-up behaves normal and pop-up only once per visitor/session.

    Could you make a updated version of this filter which works with your latest version of the plugin?

    Thread Starter woomigrating

    (@woomigrating)

    That sounds awesome, looking forward to the update and your help!! 🙂

    Thread Starter woomigrating

    (@woomigrating)

    It seems we finally got most of it working, I’ll get back here with a more detailed description shortly!

    Thread Starter woomigrating

    (@woomigrating)

    In the work of testing we encountered another issue/bug.

    When we move an image from a virtual folder to another, there is a query which runs for what it seems forever. If we move multiple images at once this causes our server to respond that there are to many database connections.

    The query which runs look like this:
    SELECT meta_id,meta_value FROM wp3_postmeta WHERE meta_value REGEXP ‘s:[0-9]+:”.(https\://dev\.ourdomain\.com/wp\-content/uploads/brands/filename\-150×150\.jpg|/brands/filename\-150×150\.jpg).”;’

    We don’t think this ongoing query is even necessary since our image virtual path is already changed and the image is displayed in the correct virtual folder in both languages directly after drag-and-drop.

    We’re not sure what purpose this query has, but is it possible for you/us to disable it?

    Thread Starter woomigrating

    (@woomigrating)

    Thank you!
    Initial testing on local looks promising. Will do more extensive testing tomorrow/Monday and getting back here with results!

    Thread Starter woomigrating

    (@woomigrating)

    Would it be possible for you to send us the plugin with the fix for general cases?
    We wont use the Media Editor, and this way we can launch the shop.

    Thread Starter woomigrating

    (@woomigrating)

    Sorry to stress you, but do you have a new time frame on the fix?
    (we are ready to go live with our site as soon as this is solved)

    Thanks!

    Thread Starter woomigrating

    (@woomigrating)

    That sounds great!

    Thread Starter woomigrating

    (@woomigrating)

    We made another test like following:
    1. In default language only; we create new virtual folder.
    2. In default language only; we upload a image to this new virtual folder.
    We 100% surely did NOT upload this image twice!

    After this we have 2 _wp_attached_file entries for this new image.
    One for primary language with correct image path (folder/image.jpg)
    One for secondary language with image path to root (image.jpg)
    We have only 1 actual file on disk, in the same path as _wp_attached_file holds for primary language (folder/image.jpg).

    In Media Library for the secondary language we have the virtual folder “/folder/”, but it’s empty. For the secondary language we find the image.jpg in the root.

    If we assign the image from virtual path “folder/image.jpg” to a product for primary language, it does not display for the secondary language.

    What procedure do we need to do to make the image appear on front-end for both languages?

    —————————————————————————
    Here below is the problem described by the developer who is helping us with this and who has spent much more time on this issue than myself.
    —————————————————————————

    Let me explain our situation.

    We don’t have virtual folders in different languages. All our real folders are in our Main language.
    We agree that the real file on the website is only one.
    But there are several posts which are related to this file.

    Part I. WPML

    When we upload an image to your virtual folder in Main language for our website (in your example it was English), WPML Media add-on creates posts (post_type = ‘attachment’ and post_mime_type = ‘image/jpeg’) for EACH languages on the website and creates relations between them in the wp_icl_translations table.

    For each of these posts in the wp_postmeta table there is must be a path to the real image on the website (‘_wp_attached_file’ = ‘customfolder/image1’). But this path is specified only for the message in the main language. For the post in the other languages path is ‘image1’, without ‘customfolder’.
    Also your plugin adds to virtual folders structure only one post in Main language.

    For example:
    We uplouded an image to the virtual folder ‘customfolder’. And WPML create two posts with IDs 31773 and 31774 in two languages.
    But your plugin changes path only for one post in main language.

    in the DB we can see following:
    wp3_term_relationships
    31773 [term_taxonomy_id]
    but post with ID 31774 was not added to this term_taxonomy_id.
    it explains why it displays in the root folder.

    postmeta table
    31773 ‘_wp_attached_file’ = ‘customfolder/image1’
    31774 ‘_wp_attached_file’ = ‘image1’

    Part II. Products with images

    For example:
    We created a product in main language with ID 31780 and added to it a featured image in the same language 31773. In the DB we can see following:

    31780 ‘_thumbnail_id’ = 31773

    Then we created a translation of this product and it was created with ID 31781.

    in the DB we can see following:
    31780 ‘_thumbnail_id’ = 31773 => post in Main language
    31781 ‘_thumbnail_id’ = 31774 => post in Second language

    The WPML plugin knows about image translation and set it as a thumbnail to the product translation.

    So…. We have a situation when the translation of product is related to the translation images in which set path to the root folder but there is not our real image file.
    For this translated image we can’t regenerate thumbnails because there is not a real file too.
    AND we can’t see an image on the single product page for product in Second Language.

    Could you consider our problem and add the plugin following behavior:

    1.When your plugin updates ‘_wp_attached_file’ for the image in main language, please check following:
    are there in the wp_icl_translations table ids of posts in different languages? and update ‘_wp_attached_file’ for all of them.
    It will fix regeneration thumbnails process and display

    2.Set virtual forder taxonomy for all of these posts in the wp3_term_relationships table.
    It will fix displaying images in the correct folders for different languages.

    Thank in advance.

    Thread Starter woomigrating

    (@woomigrating)

    When we add a image to a virtual folder in “Media Folder” library the image appears in the correct folder for the primary language, but for secondary language the image appears in the root folder.

    This is because the image-url for some reason doesn’t update for the 2nd language entries in DB.

Viewing 14 replies - 16 through 29 (of 29 total)