timjh

Simon – thanks for updating me. Coincidentally, I had just spent a bit of time this week implementing a marker index. Today’s task was to make it work with v1.3 :-(. You can see it in action on the page referenced in my original post.

I had to hack os-datahub-maps.js to capture handles to (a) the map and (b) an array of marker layers (I wonder if there is a better way to get at these?).

I used a do_shortcode_tag hook on [osmap] to append the name index below the map. In the index, each name is a link to the map (to make it scroll into view) and holds a data attribute for the array index of the relevant marker layer.

My JS script, responding to a click on a name, takes just a few lines to retrieve the marker index, fly to the marker and pop it open.

I don’t like the long list of names in a single column, but a bit of CSS will fix that shortly.

Thanks very much for finding that reference, and yes, I think your suggested approach would work for me. The order of the list would be important – presumably it would be simple to preserve the order in which the markers are defined in the markerfile or markers list.

Thinking about a bit more generalisation: Obviously each list item should default to showing the marker label, but it might be nice to be able to modify it for display – perhaps via a hook? (Probably better than adding a “list-item-label” field to the already complex marker definition.) It might also be nice to have a hook for manipulating the list, eg to drop items or re-order, or insert additional HTML for grouping purposes.

Someone may want to embed a marker link in text on the same page: they could do this by enabling the list option, copying and pasting the link from the list and then disabling the list, or suppressing it in the CSS. I would actually find it useful to embed a marker link in text on a different page; I suppose that would need some URL query parameters; perhaps a step too far :-).

The code in the reference you found looks fairly straightforward, although I’m not sure how to make it work alongside the plugin. Have I piqued your interest enough for you to add it to your to-do list? I’d willingly run tests!

• This reply was modified 4 years, 8 months ago by timjh.
• This reply was modified 4 years, 8 months ago by timjh.
• This reply was modified 4 years, 8 months ago by timjh.

Understood. Thanks for swift response. You’ve been busy over the Bank Holiday!

Thank you! I’ve made it stand out a bit more with CSS:

.os-datahub-map .leaflet-control-scale-line {
  background-color: rgba(255, 255, 255, 0.8);
  font-size: larger;
  font-weight: bold;
}

• This reply was modified 5 years, 7 months ago by timjh.