Matt
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Activity Log] Updating plugins via InfiniteWP does not log in WSALHow is it that simple history was able to log it then?
Forum: Plugins
In reply to: [Publish View] "Preview Changes" button not opening new tab anymoreThis is rediculous. What is the point of this change? You are completely removing a great feature of being able to preview a post.
To fix this comment out line 59 in publish-view.php:
/*echo '<script>jQuery(\'#post-preview\').attr(\'target\',\'_self\');jQuery(\'#message.updated a\').removeAttr(\'target\');</script>';*/Please fix!
Was very excited to see “Fixed: carousel items width calculation” in the latest release notes. Unfortunately it doesn’t seem to have fixed this issue.
Forum: Plugins
In reply to: [Responsive Lightbox & Gallery] Problem with add_gallery_lightbox_selectorNegative. The place where I’m using it is not front facing at the moment. You should be able to replicate it by turning on the auto lightbox option, uploading a PDF, and then viewing the attachment page for it.
bump
Forum: Plugins
In reply to: [Responsive Lightbox & Gallery] Problem with add_gallery_lightbox_selectorStill not fixed.
So yes, it is definitely related to the apostrophe in the link. Looks like it’s being passed in as a “fancy” apostrophe–
"Newsweek’s" as opposed to "Newsweek's"
and that is causing redirection to throw the error. I have a regex redirection setup to redirect “^\/board\/.*” to another URL.bump. still happening. seems to be related to the same PDF. possibly because of the apostrophe in it?
Forum: Plugins
In reply to: [Really Simple Share] Can we disable the readyshare stuff completely?Just putting it out there that you need to come up with a better method of disabling readyshare. Having to remember to “disable it” after every plug in update by clicking that link which just deletes a file is a terrible solution.
I still say though that regardless of what the setting are, AIO SEO is the one setting the title, and it’s setting it in a way that should be avoided. No matter what settings I have, it should never put a separator in when there is nothing to separate. Plain and simple.
Rewrite titles is turned on. The homepage is set to a static page (the static page option is NOT turned on under “home page settings.” And the “Home Page Title Format” is set to “%page_title%” (default, I believe). If I change it to “%blog_title%” the problem goes away.
This is what I know… by default the theme on this particular site (https://wordpress.org/themes/bouquet/) has this in the header.php:
<title><?php wp_title( '|', true, 'right' ); ?></title>The ‘tagline’ is set to blank. And with AIO enabled, the title shows up as: “Title | “.
Even if I change the header line to:
<title><?php wp_title( ' ', true, 'right' ); ?></title>(which is not what I want, just an example) AIO SEO still overwrites it the same way. I have to apply the filter that I wrote in the first post in order to set it how I want it.Actually I just checked and the theme on the site I was working with does not add support for title-tag. However, the default value of $sep for function get_original_title is “|” so it’s essentially the same.
I don’t know if my workaround is throwing you off, but I only posted that as a workaround for others until something is changed in the meantime. It wasn’t to offer a fix for the problem.
In aioseop_class.php you have this:
function get_original_title( $sep = '|', $echo = false, $seplocation = '' ) { global $aioseop_options; if ( !empty( $aioseop_options['aiosp_use_original_title'] ) ) { $has_filter = has_filter( 'wp_title', Array( $this, 'wp_title' ) ); if ( $has_filter !== false ) remove_filter( 'wp_title', Array( $this, 'wp_title' ), $has_filter ); if ( current_theme_supports( 'title-tag' ) ) { $sep = '|'; $echo = false; $seplocation = 'right'; } $title = wp_title( $sep, $echo, $seplocation ); if ( $has_filter !== false ) add_filter( 'wp_title', Array( $this, 'wp_title' ), $has_filter ); if ( $title && ( $title = trim( $title ) ) ) return trim( $title ); } [...]I’m pretty sure–
if ( current_theme_supports( 'title-tag' ) ) { $sep = '|'; $echo = false; $seplocation = 'right'; } $title = wp_title( $sep, $echo, $seplocation );is what was causing my issue. And because you are removing previous filters, I had to filter on the only one you provide (“apply_filters( ‘aioseop_title’, $title );”) later.
Forum: Plugins
In reply to: [HTML5shiv for WordPress] Plugin doesn't load??Englighten on how it gets queued up. Your plugin’s PHP contains this:
function rw_html5shiv() { // Original wp_deregister_script('html5shiv'); // deregister //wp_enqueue_script('html5shiv', plugins_url('/js/html5shiv.min.js', __FILE__), false, '3.7.2'); // With Printshiv wp_deregister_script('html5shiv-printshiv'); // deregister wp_enqueue_script('html5shiv-printshiv', plugins_url('/js/html5shiv-printshiv.min.js', __FILE__), false, '3.7.2'); }Yet nothing actually calls rw_html5shiv, so it never does anything.