Matt

I don’t have the resources to test a subdomain install at the moment.

Sorry, saw this when you replied and then forgot about it. I have not tested it on a subdomain install but I don’t see how that would be any different. Still matching the whole beginning part of the site url. I have done two more posts on my own site since the modification and it’s working.

Yes, I have define( 'UPLOADS', 'media' ); in my wp-config and then I am using the ‘upload_dir’ filter as follows. Basically I am replacing the site ID with the site path and then adding in ‘posts’. Lastly just replacing the post date with todays date. I removed some stuff I do with pages and really I think the only thing relevant is what’s in the if (is_multisite()) { block but left the rest in anyway.

function custom_upload_dir( $param ) {
	$blog_id = 1;
	if (is_multisite()) {
		$blog_id = get_current_blog_id();
		if ($blog_id > 1 && substr(strrev($param['basedir']), 0, strlen('/sites/'.$blog_id)) == strrev("/sites/$blog_id")) {
			$network_path = network_home_url( '', 'relative' );
			$site_path = home_url( '', 'relative' );
			$site_path = str_ireplace($network_path, '', $site_path);

			$param['path'] = str_replace("/sites/$blog_id", "/sites/".$site_path, $param['path']);
			$param['basedir'] = str_replace("/sites/$blog_id", "/sites/".$site_path, $param['basedir']);
			$param['url'] = str_replace("/sites/$blog_id", "/sites/".$site_path, $param['url']);
			$param['baseurl'] = str_replace("/sites/$blog_id", "/sites/".$site_path, $param['baseurl']);
		}
	}

	if ( isset( $_REQUEST['post_id'] ) ) {
		$post_id = absint( $_REQUEST['post_id'] );
		$post = get_post($post_id);
	}

	if (!empty($post)) { $post_type = get_post_type($post); }
	if (!empty($post_id) && !empty($post)) {
		$breadcrumbs = array();
		if ($post_type == 'page') {
			//edited out as not applicable
		} elseif ($post_type == 'post') {
			$breadcrumbs[] = 'posts';
		}

		if (!empty($breadcrumbs)) {
			$breadcrumbs = array_reverse($breadcrumbs);
			$path_to_insert = implode("/", $breadcrumbs);

			$new_path = $param['basedir'] . '\\' . $path_to_insert . substr($param['path'], strlen($param['basedir']));
			$new_url = $param['baseurl'] . '/' . $path_to_insert . substr($param['url'], strlen($param['baseurl']));

			$param['path'] = $new_path;
			$param['url'] = $new_url;
		}

		$y = ''; $m = ''; $d = '';
		$time = get_the_time('Y-m-d', $post);
		if (strlen($time) == 10) {
			$y = substr( $time, 0, 4 );
			$m = substr( $time, 5, 2 );
			$d = substr( $time, 8, 2 );
		}

		//replace post date with today's date
		if (strlen($y.$m.$d) == 8 && substr(strrev($param['path']), 0, 7) == strrev($y.'/'.$m)) {
			$add_to_dir = date("Y")."/".date("m");
			$param['path'] = substr($param['path'], 0, strlen($param['path'])-7).$add_to_dir;
			$param['url'] = substr($param['url'], 0, strlen($param['url'])-7).$add_to_dir;
		}
	}
    return $param;
}
add_filter('upload_dir', 'custom_upload_dir');

They could be running outdated WP?

I can see how that would work but I thought it would be simpler just to move the following code out of that function:

// get groups to check it faster
$groups = Post_Views_Counter()->options['display']['restrict_display']['groups'];

// whether to display views
if ( is_user_logged_in() ) {
	// exclude logged in users?
	if ( in_array( 'users', $groups, true ) )
		return $content;
	// exclude specific roles?
	elseif ( in_array( 'roles', $groups, true ) && Post_Views_Counter()->_counter->is_user_roles_excluded( Post_Views_Counter()->options['display']['restrict_display']['roles'] ) )
		return $content;
}
// exclude guests?
elseif ( in_array( 'guests', $groups, true ) )
	return $content;

Modify into a function as such:

function pvc_is_restricted() {
	// get groups to check it faster
	$groups = Post_Views_Counter()->options['display']['restrict_display']['groups'];

	// whether to display views
	if ( is_user_logged_in() ) {
		// exclude logged in users?
		if ( in_array( 'users', $groups, true ) )
			return TRUE;
		// exclude specific roles?
		elseif ( in_array( 'roles', $groups, true ) && Post_Views_Counter()->_counter->is_user_roles_excluded( Post_Views_Counter()->options['display']['restrict_display']['roles'] ) )
			return TRUE;
	}
	// exclude guests?
	elseif ( in_array( 'guests', $groups, true ) )
		return TRUE;

	return FALSE;
}

And then update the original function:

public function add_post_views_count( $content ) {
	if ( is_singular() && in_array( get_post_type(), Post_Views_Counter()->options['display']['post_types_display'], true ) ) {

		if (pvc_is_restricted()) return $content;

		switch ( Post_Views_Counter()->options['display']['position'] ) {
			case 'after':
				return $content . '[post-views]';

			case 'before':
				return '[post-views]' . $content;

			default:
			case 'manual':
				return $content;
		}
	}

	return $content;
}

… and then theme authors could use pvc_is_restricted() to test if the views should be displayed or not.

Yup, all good.

edit: Sorry, marked it as resolved. Just noticed you meant to leave it unresolved.

There is no need for any img-tags, so the second test will exclude lots of potential valid uses.

Yea that’s certainly a mistake and not something I considered.

What you’re doing here is taking a very straightforward default behaviour (eg: if it’s not “lightbox” it’s not lightboxed), inverts it and end up making the problem vastly more complicated to solve.

You lost me here. The plugin automatically light boxes links without having to manually specify “lightbox.” You previously had instructed that if you want to override the lightbox, then specify anything in the rel field. This would cause the plugin to add a second rel tag which would inevitably break the jquery selector from selecting it and also what caused the problem with the latest version of WordPress (the new version of WP puts these tags in automatically now).

The fix that I outlined was to allow for the automatic light boxing of images that already have data in the rel tag. I haven’t gotten a chance to see what changes you’ve made to update the plugin but the idea of me adding support for “nolb” , “nobox” etc was to provide a way for a link NOT to get automatically lightboxed. Other plugins use similar words to prevent auto-lightboxing so it kind of makes it easier for users to switch between if they are supported.

That’s a fair point. I might look into letting WP jQuery Lightbox play nice with other users of the rel-attribute. 🙂

Again I’m confused… All users of the latest WP version are using the rel attribute now. WP automatically inserts tags in there.