Sutherland Boswell

Did a little testing myself and apparently the post’s status must be getting changed to draft before being privately published. I managed to get draft_to_private to work after creating a new post, switching it to private, and then clicking “Update”.

I think the solution may be to just simplify things and only use the save_post hook.

I tested this out and it seems to work fine, can do a little testing to see if it works for you without creating duplicate images?

// Find video thumbnail when saving a post, but not on autosave or revisions

add_action( 'save_post', 'save_video_thumbnail', 10, 1 );

function save_video_thumbnail( $post_id ) {
	if ( !wp_is_post_revision( $post_id ) ) {
		$post_type = get_post_type( $post_id );
		$video_thumbnails_post_types = get_option( 'video_thumbnails_post_types' );
		if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
			return null;
		} else {
			// Check that Video Thumbnails are enabled for current post type
			if ( in_array( $post_type, (array) $video_thumbnails_post_types ) || $post_type == $video_thumbnails_post_types ) {
				get_video_thumbnail( $post->ID );
			} else {
				return null;
			}
		}
	}
}

Thanks again for your help!

That’s odd, it’s supposed to exist

I just tested it out with that URL but it worked for me, can you try it with a Vimeo video and see if it works for that?

Can you try adding add_action('new_to_private', 'save_video_thumbnail', 10, 1); to the section below and let me know if that fixes the problem for private posts?

add_action('new_to_publish', 'save_video_thumbnail', 10, 1);
add_action('draft_to_publish', 'save_video_thumbnail', 10, 1);
add_action('pending_to_publish', 'save_video_thumbnail', 10, 1);
add_action('future_to_publish', 'save_video_thumbnail', 10, 1);

Early on I was having trouble getting the action to run without creating duplicates for every revision or auto-save, and adding actions for these post status transitions was the best solution I could come up with at the time. I’m gonna be working on version 2.0 soon (your help has provided a good motivation) with several optimizations and this is probably one of the things I’ll try to improve.

I think the best solution would be to store the image’s media library ID in the custom field instead of an absolute path. This would make things a lot more flexible and manageable all around for people who want to delete all video thumbnails, change domains, get different media sizes, etc.

The fact URLs are stored is a remnant of the early versions when images weren’t being saved to the local media library. I think it’s about time to drop support for storing non-local URLs.

Another thing that might help would be custom fields for attachments created by video thumbnails, that way a user could click a button and any media with a field like ‘is_video_thumbnail’ could be wiped out.

I don’t think this is something we need to worry about, because the links (at least those the core supports) should already be converted to their embed code by applying the content filter.

$markup = $post_array->post_content;
$markup = apply_filters('the_content',$markup);

This is also supposed to take care of any videos embedded using plugins with their own shortcode or URL structure, but for some reason this isn’t always the case. Maybe try testing out this section to see if it is in fact converting most videos from the core and plugins to their embed code.

@Chozen @bazel it sounds like maybe the custom fields aren’t being saved until after the Video Thumbnail action. Try changing

add_action('new_to_publish', 'save_video_thumbnail', 10, 1);
add_action('draft_to_publish', 'save_video_thumbnail', 10, 1);
add_action('pending_to_publish', 'save_video_thumbnail', 10, 1);
add_action('future_to_publish', 'save_video_thumbnail', 10, 1);

in the plugin file to

add_action('new_to_publish', 'save_video_thumbnail', 20, 1);
add_action('draft_to_publish', 'save_video_thumbnail', 20, 1);
add_action('pending_to_publish', 'save_video_thumbnail', 20, 1);
add_action('future_to_publish', 'save_video_thumbnail', 20, 1);

and let me know if this fixes the problem for you. I’m going to try to include official custom field support in an upcoming version, and I’ll include this change if it fixes your problem.