phbernard

Thank you for your feedback!

Thanks for the review!

You’re welcome! Thanks for your feedback!

Thank you!

… which is the latest version.

Really strange. I’ve just check my own blog, to get the exact same settings as yours (so modified files locally, etc.). I also have v1.3.1 and:

• RFG_FILES_URLS is declared on line 7
• RFG_FILES_URLS is used on line 49 (not 47)

The beginning of my version of wordpress/wp-content/plugins/favicon-by-realfavicongenerator/admin/class-favicon-by-realfavicongenerator-api-response.php:

[ Moderator note: code fixed. Please wrap code in the backtick character or use the code button. ]

<?php
// Copyright 2014 RealFaviconGenerator

define( 'RFG_PACKAGE_URL',                  'package_url' );
define( 'RFG_COMPRESSION',                  'compression' );
define( 'RFG_HTML_CODE',                    'html_code' );
define( 'RFG_FILES_URLS',                   'files_url' );
define( 'RFG_FILES_IN_ROOT',                'files_in_root' );
define( 'RFG_FILES_PATH',                   'files_path' );
define( 'RFG_PREVIEW_PICTURE_URL',          'preview_picture_url' );
define( 'RFG_CUSTOM_PARAMETER',             'custom_parameter' );
define( 'RFG_VERSION',                      'version' );
define( 'RFG_NON_INTERACTIVE_API_REQUEST',  'non_interactive_api_request' );

define( 'RFG_FAVICON_PRODUCTION_PACKAGE_PATH',   'favicon_production_package_path' );
define( 'RFG_FAVICON_COMPRESSED_PACKAGE_PATH',   'favicon_compressed_package_path' );
define( 'RFG_FAVICON_UNCOMPRESSED_PACKAGE_PATH', 'favicon_uncompressed_package_path' );
define( 'RFG_PREVIEW_PATH',                      'preview_path' );

class Favicon_By_RealFaviconGenerator_Api_Response {

        private $params = array();

        public function Favicon_By_RealFaviconGenerator_Api_Response( $json ) {
                if ( $json == NULL ) {
                        throw new InvalidArgumentException( "No response from RealFaviconGenerator" );
                }

                $response = json_decode( $json, true );

                if ( $response == NULL ) {
                        throw new InvalidArgumentException( "JSON could not be parsed" );
                }

                $response = $this->getParam( $response, 'favicon_generation_result' );
                $result = $this->getParam( $response, 'result' );
                $status = $this->getParam( $result, 'status' );

                if ( $status != 'success' ) {
                        $msg = $this->getParam( $result, 'error_message', false );
                        $msg = $msg != NULL ? $msg : 'An error occured';
                        throw new InvalidArgumentException( $msg );
                }

                $favicon = $this->getParam( $response, 'favicon' );
                $this->params[RFG_PACKAGE_URL] = $this->getParam( $favicon, 'package_url' );
                $this->params[RFG_COMPRESSION] = $this->getParam( $favicon, 'compression' ) == 'true';
                $this->params[RFG_HTML_CODE] = $this->getParam( $favicon, 'html_code' );
                $this->params[RFG_FILES_URLS] = $this->getParam( $favicon, 'files_urls' );
...

Any chance your file has modifications?

If you don’t want to bother too much, you can mail it to me at contact@realfavicongenerator.net

Thank you Kenny! Come back soon! 😉

You’re welcome! Thank you for your review!

Great review. Thanks! 🙂