pavelevap
Forum Replies Created
-
Forum: Plugins
In reply to: [České služby pro WordPress] Nová struktura feedu Zboží.czTo by asi také šlo, ale nejjednodušší je použít políčka pro Heureku (pokud Heureku nepoužíváte), doplnit si tam potřebné kategorie pro Zboží a následně upravit:
$strom_kategorie = ceske_sluzby_xml_ziskat_kategorie_produktu( $product_id, false, false, '|' );aby to odpovídalo kódu z Heureky:
$strom_kategorie = ceske_sluzby_xml_ziskat_kategorie_produktu( $product_id, 'ceske_sluzby_xml_heureka_kategorie', 'ceske-sluzby-xml-heureka-kategorie', '|' );Forum: Plugins
In reply to: [České služby pro WordPress] Nová struktura feedu Zboží.cz@janbrokes: Je to možné u každé kategorie nebo přímo u každého produktu, ale zatím pouze pro Heureku (Zboží.cz a Google budu teprve přidávat).
Forum: Plugins
In reply to: [České služby pro WordPress] Nová struktura feedu Zboží.cz@janbrokes: Pokud používáte feed v podobě souboru (tedy
/zbozi.xml), tak je automaticky generován jednou denně (chystá se i tlačítko pro možnost okamžitého vygenerování). A pokud používáte jen jednoduchý odkaz (tedy?/feed=zbozi), tak by měla být změna viditelná ihned (pozor na cachování prohlížeče, zkuste Shift + F5).Yep, it works, thank you! I did not notice that
get_plugin_data()has parameter for translation 🙂 So, in the end it is bug inside Freemius?Thank you! Sorry, but I am not sure about the real cause of this issue 🙂 These functions should be OK and are used in many other plugins, I guess. So maybe called too early or something else? Is it problem with Popup Maker, Freemius, WP core or some kind of combination? If there is any fix available, please let me know, I can test it.
Yes, commenting those lines works for me as a temporary fix. But I am not sure if something stopped working due to these comments.
I tested Ultimate Widgets Light and there is the same problem with quotes after plugin activation.
You can see example screenshot here: http://www.separatista.net/wp-content/uploads/2016/07/Popup_Maker_wrong_quotes.jpg
NextGEN Gallery works without problems, their functions are available here. But I am not experienced with Freemius integration, so I am not sure what is different.
OK, I was able to backtrace it after further testing. I checked all
wptexturize()calls and compare them with/without Popup Maker activated. And this was the particular call which broke quotes:require('C:\www\wordpress\src\wp-blog-header.php'), require_once('C:\www\wordpress\src\wp-load.php'), require_once('C:\www\wordpress\wp-config.php'), require_once('C:\www\wordpress\src\wp-settings.php'), include_once('C:\www\wordpress\src\wp-content\plugins\popup-maker\popup-maker.php'), pum_fs, PUM_Freemius::instance, PUM_Freemius->fs, fs_dynamic_init, Freemius::instance, Freemius->__construct, Freemius->_version_updates_handler, Freemius->get_plugin_version, Freemius->get_plugin_data, get_plugin_data, _get_plugin_data_markup_translate, wptexturizeI commented in
class-freemius.phpparticular line 282.But then there were other call:
require('C:\www\wordpress\src\wp-blog-header.php'), require_once('C:\www\wordpress\src\wp-load.php'), require_once('C:\www\wordpress\wp-config.php'), require_once('C:\www\wordpress\src\wp-settings.php'), include_once('C:\www\wordpress\src\wp-content\plugins\popup-maker\popup-maker.php'), pum_fs, PUM_Freemius::instance, PUM_Freemius->fs, fs_dynamic_init, Freemius->dynamic_init, Freemius->parse_settings, Freemius->get_plugin_version, Freemius->get_plugin_data, get_plugin_data, _get_plugin_data_markup_translate, wptexturizeSo, I commented lines 2177 and 2178 and quotes magically work now.
Root issue is hidden in
wptexturize()call inside WP function_get_plugin_data_markup_translate()and related WP plugin functions are probably loaded inside Freemius before localization functions (or there is some other issue with them).Note: Filter
run_wptexturizeis for other purposes and does not influence$resetparam.Hi,
I tried removing almost all filters, but it is coming probably from Freemius, because of
pum_fs(). I noticed that there are several calls throughout their codebase which are used very early:require_once( ABSPATH . 'wp-admin/includes/plugin.php' );If some of these calls are used before localization files are correctly loaded, then
wptexturize()can be wrong for the first load, because it is running inside this file, for example here.But I am not sure about it, because I tried following code and it did not help 🙁
add_filter( 'run_wptexturize', '__return_false' );Are you able to reproduce this problem?
Hi,
sorry, but no change, quotes are still wrong until Popup Maker is deactivated 🙁
Hi,
any news about this issue?
Forum: Plugins
In reply to: [České služby pro WordPress] Ceny bez DphDíky za otestování, do konce července by měla být dostupná nová verze i oficiální cestou…
Forum: Plugins
In reply to: [České služby pro WordPress] Ceny bez DphForum: Plugins
In reply to: [České služby pro WordPress] Nová struktura feedu Zboží.czNejnovější verze
0.5-alphauž by ho měla podporovat. Můžete si ji prosím stáhnout a vyzkoušet? Oficiálně vyjde verze 0.5 během července, ale uvítal bych zájemce o otestování novinek.Hi,
any news about this issue?
Forum: Hacks
In reply to: Plugin translationsRelated discussion: http://www.separatista.net/forum/tema/preklady-pluginu-glotpress-jak-to-funguje (in Czech)