oooorgle
Forum Replies Created
-
Forum: Plugins
In reply to: [Quotes llama] Possibilty to use HTML tags in Quotes and SourceHere is what I am thinking so far:
Tag | Attribute
a | href, target, rel, class, title
b |
br | clear
del |
em |
i |
mark |
small |
strong |
sub |
sup |
u |Then:
- A check for missing closed tags as to not bleed out all over the rest the page.
My main concern is injection attacks. Some kind of code I’m unaware of that could still be passed. I’ve tested for all I can think of and it seems good. Please share any ideas or concerns regarding security and this change to the plugin… anyone else too.
Formatting buttons?… 😉
Any other ideas are welcome.- This reply was modified 3 years, 8 months ago by oooorgle.
Forum: Plugins
In reply to: [Quotes llama] HTML Tags and Source link not working anymoreThe href linking is in the same boat as the bold formatting. If I can figure an acceptable way to do without compromising security (which I think I have a good idea how) then that will be something available with the formatting options. Let’s do close this thread and create another specific to the formatting options. If you don’t mind perhaps provide a list of the html tags you want to use in the new thread: Thanks!
(tag –> attribute)
‘a’ –> ‘href, rel, class.
‘strong’
‘br’Forum: Plugins
In reply to: [Quotes llama] HTML Tags and Source link not working anymore= Version 1.1.1 = Update notes.
* **Fix** Since last update, the source arrow icon is displaying in the author field when there is no source. (identified by: gendji)
* **Fix** Debug warning ‘characters in header’ when importing quotes. Moved echo into return.
* **Add** Expand the use of make_clickable to filter URL protocols from displaying in text links. (suggested by: gendji)
* **Add** Options setting to omit/display URL protocols in text links.Let me know how it works 😉
Forum: Plugins
In reply to: [Quotes llama] HTML Tags and Source link not working anymorePrevious versions before 1.0.0 have security issues and should not be used. That I could enter <br> also meant I could enter an XSS attack and have it accepted by the database. HTML tags are now filtered (sanitize_textarea_field) to “lessen the possibility of XSS vulnerabilities and MITM attacks…” The Henry Beston quote with <br><br> can now be displayed using two (Enter) or (Shift+Enter) in the quote field.
Fields are run through the Make_Clickable function which allows entering just urls, email addresses etc with no HTML tags. The Cleveland Amory quote should now display a proper link… I was esc_html instead of wp_kses_post on it. If it still shows the tags, perhaps try editing the quote and remove them there since it may have stored them directly into the string. The Same thing for the Terry Pratchet quote displaying the slash.
The bold … I’m going to have to give that some thought how to get that and other styling to work. It would be cool be able to <i> etc. too.
I’ve updated to version 1.1.0 and will keep the styling in mind. Let me know how it’s working with the rest. Thanks!
- This reply was modified 3 years, 8 months ago by oooorgle.
Forum: Plugins
In reply to: [Quotes llama] HTML Tags and Source link not working anymoreThanks for the heads up! I will get this fixed within the next few days and let you know.
Forum: Plugins
In reply to: [Quotes llama] [BUG] Undefined constant REQUEST_URI in class-quotesllama.php== Changelog ==
= Version 1.0.1 =
* **Fix** Ommitted quotes. $_server environment entries are not quoted. (identified by: fidoboy)== Changelog ==
= Version 1.0.1 =
* **Fix** Unnecessary option. Function call with a required parameter after an optional parameter. “738 of class-quotesllama-list-table.php” (identified by: fidoboy)Forum: Plugins
In reply to: [Quotes llama] [BUG] Undefined constant REQUEST_URI in class-quotesllama.phpYou are the best! Will be fixed in next update.
Thank you! This will be implemented very soon.
https://php.watch/versions/8.0/deprecate-required-param-after-optionalForum: Plugins
In reply to: [Quotes llama] Create more then one gallery?Forum: Plugins
In reply to: [Quotes llama] Random Not Working?Could someone who is having this problem try testing the changes suggested by rehernandez? Simply replace the quotes-llama.php file in the plugin directory with this one http://oooorgle.com/downloads/quotes_llama/quotes-llama.zip
What it is basically doing is having PHP select the random quote rather than SQL. Be sure to clear your cache too ;). Thanks!
Forum: Plugins
In reply to: [Quotes llama] Random Not Working?Hi rehernandez! Thanks for the suggestion. My fingers are crossed it performs better.
Forum: Plugins
In reply to: [Quotes llama] Any plan for feeds and direct linkHi Salvatore! Sorry so late, been out of town with work… got 1 day off before going back for another 2 week lapse in internet access.
1. Does
[quotes-llama id="#,#,#"]happen to provide what you need for quote by ID?
2. I will put “sharing on social media” on the task list and see what might come of it.
3. I will put “RSS feed of recent” on the task list too.Let me know about the ID and anything else and I’ll try to be prompt when I return from work. As always, I appreciate the great suggestions and tips.
Forum: Plugins
In reply to: [Quotes llama] Random Not Working?Thanks for testing that. I’ll get back when I have something… Suggestions from the WP community are welcome.
Forum: Plugins
In reply to: [Quotes llama] Create more then one gallery?I see your page is still displaying the same issue. I’ve another possibility of how to maybe fix my problem here https://wordpress.org/support/topic/random-not-working-3/#post-9196308
What I need now is someone who is having the problem test and see if it works.