oc1978

Ok, I’ve checked a bunch of the code now and I think this:

“Notice: Undefined variable: features in /wordpress/wp-admin/includes/theme-install.php on line 84”

is a bug. (Or laziness.)

I might be wrong of course as I haven’t looked a lot at it, but I’ve grepped all the $features in the source and looked at the functions where they are contained (and some of the functions the functions are calling) and this code:

function install_themes_feature_list( ) {
    print("now!");
	if ( !$cache = get_transient( 'wporg_theme_feature_list' ) )
		set_transient( 'wporg_theme_feature_list', array( ),  10800);

	if ( $cache  )
		return $cache;

	$feature_list = themes_api( 'feature_list', array( ) );
	if ( is_wp_error( $feature_list ) )
		return $features;

	set_transient( 'wporg_theme_feature_list', $feature_list, 10800 );

	return $feature_list;
}

returns a variable that hasn’t been set.

Anyway, I don’t have any more time to check through the code as I’m not familiar with it and this wasn’t really how I was gonna spend my evening. 😉

I don’t know if the two errors are related though.

Confusing use of global in the code too.