Bernhard Riedl

Cool. – You found the issue. 🙂 I’m also curious, so here’s an idea:

As I also use a pre_get_posts-filter to manipulate the post_type in $wp_query, it looks to me like a race condition between the two filters.

Your code sets the post_type to array('post', 'software', 'documents', 'news', 'nav_menu_item', 'page'); if the post_type has not been set before.

TagPages sets the post_type to array('post', 'page') if the post_type has not been set before.

So, if the TagPages-filter is executed before your filter, it will never reach your else-fork.

The default $priority = 10 for all filters, so I think setting your function to a higher priority (e.g. to 9) would achieve the desired functionality.

Hi huyz,

Thanks for the info and the link. – I’ve implemented the changes but unfortunately have no environment setup for testing. – Could you help me out and give the new version a spin on your system?

Here’s a link to my mail-address.

Cheers,
Berny

No, it doesn’t. – This meta-tag is solely dedicated to support and stats.

greetz,
Berny

Hi Drew,

That’s even more strange. – Looks like your client’s host does not have these object-related language constructs (instanceof) enabled?

Anyway, if you want to continue on testing, please let me know, I don’t have much spare time, but I’m also curious…

Greetz,
Berny

I’ve raised a ticket.

True, I also thought this would be set to any, but apparently it doesn’t. 😉 I remember having some discussions about tagging of pages on the forums when WordPress 2.3 came out, but the core devs refused to include this functionality.

So there’s maybe also a historical reason why the post_type for taxonomy queries is automatically set to post. – I didn’t debug the code, though. – If you like to you can file a ticket in trac… Btw. this also applies for the custom column which holds the tags in edit.php for pages.

Anyway, you’re right that the extension of the post-types can also be done with a filter on the query_vars rather than modifying the SQL query itself. Cheers for this tip. 🙂

Here’s the code I’ve worked out. – It should also cover the possibility of custom post-type with post-tags scenarios. Maybe you can have a look. – If you like to, I can also send you the reworked plugin by mail.

add_filter('pre_get_posts', array(&$this, 'add_page_to_tags_query'));

function add_page_to_tags_query($query) {
	if (is_tag() && !is_admin()) {

		/*
		if the post_type does not exist,
		we create it
		*/

		if (!array_key_exists('post_type', $query->query_vars))
			$query->query_vars['post_type']=array();

		/*
		if post_type is set to or includes
		any or page
		there's nothing more to do
		*/

		if (!empty($query->query_vars['post_type']) && (in_array('any', (array) $query->query_vars['post_type']) || (in_array('page', (array) $query->query_vars['post_type']))))
			return $query;

		/*
		otherwise include post and page
		into post_type
		*/
			$query->query_vars['post_type']=array_unique(array_merge((array) $query->query_vars['post_type'], array('post', 'page')));
	}

	return $query;
}