mvied
Forum Replies Created
-
I suppose I chose “can” because “should” implies that they should not be set to true, but it does not imply that they are set to true. We programmers are pretty literal in our wording, lol. I’ll probably end up changing it somehow to be a little more clear.
The plugin doesn’t break. Because the redirect isn’t pluggable, I had to re-implement FORCE_SSL_ADMIN as a setting in the plugin, Force SSL Admin. So if you want to use my plugin and secure your admin panel, remove FORCE_SSL_ADMIN from wp-config.php and enable Force SSL Admin on the HTTPS settings page and it should provide the same functionality.
It’s happening because it’s supposed to. FORCE_SSL_ADMIN and FORCE_SSL_LOGIN can not be set to true in your wp-config.php, as the message states. There is code on WordPress’ login page that redirects to HTTPS if either of those are set in wp-config.php. The redirect is not pluggable, so it can cause issues that conflict with the plugin.
No problem. Don’t mind if I do. π
Ah, I see. That makes sense.
The real problem is my plugin is changing that URL to HTTP when it really shouldn’t be, then WooCommerce’s Force Secure Checkout setting was redirecting that call back to HTTPS and breaking it.
In the next version I’m going to be changing the code up and WooCommerce’s Force Secure Checkout should no longer conflict.
If http://www.vapebig.com/checkout-2/pay/ was secured I’m pretty sure the plugin would fix it. Check again.
It’s hitting http://www.vapebig.com/checkout-2/pay/ and then being redirected to https://www.vapebig.com/checkout-2/pay/ and screwing up the check out. Is https://www.vapebig.com/checkout-2/pay/ a page you can secure with the plugin?
Do you have a way that I could test it?
I emailed you a few minutes ago Wendel. I’m interested to see what’s going on.
Sure, I already explained it above.
If someone is using a service like CloudFlare or some other caching mechanism, pulling HTTPS resources on the HTTP page may prevent those caching services from working correctly.
I will consider an option for turning this off, however, I’d like to keep the settings minimal.
Sure.
https://github.com/Mvied/wordpress-https/blob/master/lib/WordPressHTTPS/Module/Parser.php#L211
Here in the Parser module (the module that controls the output buffering processing) if the Site URL is not set to HTTPS, every occurrence of the HTTPS version of the Site URL is replaced with HTTP in the HTML output.
Now that I think about it, I know why it’s happening. There’s really no way to prevent it from changing the URL to HTTP. I would suggest placing the code in a separate file, or leaving it how you have it now.
Since resetting have you tried opening the site in a new tab to rule out browser cache?
By most recent do you mean updating from 3.0.3 to 3.0.4?
Yes, it’s a 404 page. You can use Chrome Developer Tools or Firebug in Firefox to see the header is coming back with a 404, even though the page is blank.
Forum: Plugins
In reply to: [WordPress HTTPS (SSL)] [Plugin: WordPress HTTPS (SSL)] Force SSL for usersSame code, add an else statement.
function logged_in_force_ssl( $force_ssl, $post_id ) { if ( is_user_logged_in() ) { $force_ssl = true; } else { $force_ssl = false; } return $force_ssl; } add_filter('force_ssl', 'logged_in_force_ssl', 10, 2);If you have Force SSL Admin enabled, the plugin should change any form or link that points to the login page to HTTPS. I just tested this on one of my sites to confirm. Can you post a link?