Marcel Brinkkemper
Forum Replies Created
-
Hey please don’t go that way. I haven’t told anyone what is wrong or right. I have only shared my thoughts with you. No hard feelings.
I do love your plugin, it is one of the best localization plugins I have ever used. Next time, I’ll think twice about making some suggestions on your plugin.
Okay, I guess you don’t want to update your plugin. I have made some changes to your plugin and it works for me now.
Yes, maybe, but because the site url does not have to be a part of content url, I have this setup. My plugins should also work when someone has set it up like this. (and I think so should yours)
BTW I don’t want symlinks because I need the directories separately for other purposes.In my development environment, localhost, I develop for WordPress trunk and for current stable version. Both WordPress installs share a wp-content directory.
In wp-config I have:define( 'WP_CONTENT_DIR', dirname(dirname(__FILE__)) . '/wp-content'); define( 'WP_CONTENT_URL', 'http://localhost/wp-content');So my site urls are
http://localhost/development/andhttp://localhost/wordpress/both share the content url ofhttp://localhost/wp-content/IMHO this is not a core bug. My site url and content url have to be different.
The problem is in the combined if statement.
The codestyling-localization scripts are in content_url, but the test incsp_plugin_denied_by_guard()returns false, and thus the whole if statement is false.If have an alternative wp-content location, so my site_url is http://localhost/development/ and my content url is http://localhost/wp-content/.
I found some issues in the logic to determine if it is an external script:
in codestyling-localization.php on line 2554if( stripos($url[1], content_url()) !== false && csp_plugin_denied_by_guard($url[1]) )is false because the script is on content_url, but csp_plugin_denied_by_guard() returns false.
the next test on line 2564 tests on site_url() which will return falseelseif (stripos($url[1], get_site_url()) === false && !in_array($url[1], $csp_external_scripts['cdn']['scripts']))I would propose to split the if statement on line 2554 in two parts, first check for content_url is true and the check for denied scripts, something like this:
if( stripos($url[1], content_url()) !== false ) { //internal scripts if ( csp_plugin_denied_by_guard($url[1]) ) { $dirty_scripts[] = $url[1]; $dirty_index[] = $i; if (stripos($url[1], plugins_url()) !== false || stripos($url[1], content_url().'/mu-plugins') !== false) { $dirty_plugins[] = $url[1]; }else{ $dirty_theme[] = $url[1]; } } }Forum: Plugins
In reply to: [Lazyest Gallery] WPML compatible?Lazyest Gallery is not WPML compatible
Forum: Plugins
In reply to: [Lazyest Gallery] Subfolder Slideshow short codeI see you have switched to a flash gallery
Forum: Plugins
In reply to: [Lazyest Gallery] Broken thumbnail with 1.1.18I can’t tell you the cause if I can’t check your server. Sorry.
Forum: Plugins
In reply to: [Lazyest Gallery] Subfolder Slideshow short codeSee if this works:
Add the following code to your theme functions.phpfunction lg_always_slideshow( $link ) { $link .= '&lg_show=true'; return $link; } add_filter('lazyest_folder_link', 'lg_always_slideshow');Forum: Plugins
In reply to: [Lazyest Gallery] Broken thumbnail with 1.1.18Forum: Plugins
In reply to: [Lazyest Gallery] Add tags to foldersVersion 2.0 will never be. Lazyest Gallery will be replaced by Eazyest Gallery which will support post tags.
Forum: Plugins
In reply to: [Lazyest Gallery] Broken thumbnail with 1.1.18Could have a lot of causes. check memory usage and directory permissions.
Forum: Plugins
In reply to: [Lazyest Gallery] Broken thumbnail with 1.1.18Could you please share your gallery url?
Forum: Plugins
In reply to: [Lazyest Gallery] Allow comments for images?Comment boxes are included in the slide view. However, you have to have a comments template for your gallery page.