Roy Orbitson
Forum Replies Created
-
Forum: Plugins
In reply to: [Contact Form 7] Forms always show misleading “configuration error” messagesDo you have a public Git repository on which you can accept pull requests?
Forum: Plugins
In reply to: [Disable Yoast's Structured Data] Removing Yoasts Structured dataYou should be able to see that data appear and disappear instantly in the HTML source of your site, usually viewable by pressing Ctrl + U (or Cmd + U) in your browser. If there’s no change, you probably have a cached copy from an optimisation plugin you have installed, a CDN you have in front of your site, and/or your browser. You may have to clear caches & hard reload to see the change.
This plugin’s code’s so basic, it’d only break if Yoast changed the name of the filter.
You can write a simple plugin that checks for the existence of products in the cart that are in that category and filters the
requiredoption as per this topic.Forum: Plugins
In reply to: [Products Purchase Price for WooCommerce] Breaks quick edit in Posts tableworked around this by inserting the line
if (window.woocommerce_admin)after line 1 (jQuery(function () {) in assets/js/wc_purchase_price_quick_edit.js.- This reply was modified 7 years, 6 months ago by Roy Orbitson.
@launchinteractive Would you be willing to put it on GitHub, GitLab, or somewhere?
There may be some better hashes like Murmur or CityHash, but they’re not built into PHP.
Perhaps add the version of the bundled minifier instead. If *that* changes, which probably means output changes, then the cache is busted.
I’m sure Adler is quick, it’s just more prone to collisions, which would be a site-breaking situation, I doubt the difference between calculating a few md4s and the same number of sha1s will make a noticeable difference.
That’s not ideal, you never know what external scripts will be added. Couldn’t it be left in, and ignored when reading the minifiable files? The versioned URLs get dequeued anyway, right?
Does
remove_cssjs_ver()remove that param from external and/or ignored URLs too?I don’t mean to hassle you, I’d just send pull requests if it was on GitHub or something. It’s a great plugin.
Also, Adler himself said Adler 32’s not a hash function. You could use SHA1 but put the modified date in the input so it doesn’t further increase the length of the filename (better privacy too).
- This reply was modified 7 years, 9 months ago by Roy Orbitson.
The minified code is now fine, thank you. Only problem is that the corrected resulting files have the same names, so they haven’t busted cache. Could you add your plugin version to the
hash()input?I mistakenly thought you were using JSMin.
It didn’t break on current https://www.minifier.org/ either. Looks like your packaged version is 7 Months old, therefore probably missing the fix for this issue and many others.
I activated the plugin again and it happened again. Redacted log:
2018-07-23T06:36:58+00:00 – COMPRESSING WITH MINIFY (PHP exec not available or java not found)
2018-07-23T06:36:58+00:00 – COMPRESSION COMPLETE – 27.83K savedIf I put the same code into http://compressorrater.thruhere.net/ (only JSMin checked) or other online minifiers, it’s fine. It looks like something else in your code is naively stripping single line comments from the minified files, which fails when it runs into a regexp literal that ends with a
/.Forum: Plugins
In reply to: [Exit Popup] Broken CSS solutionThanks!!