Joen Asmussen
Forum Replies Created
-
Forum: Plugins
In reply to: [Gutenberg] Suggestion: Text Width in Gutenberg Based on ThemeYou should absolutely be welcome to create issues. However I’d look for existing issues first, I’m almost certain there are tickets for 5 and 6, and there’s possibly for the others.
Thanks for your help!
Forum: Plugins
In reply to: [Gutenberg] Suggestion: Text Width in Gutenberg Based on ThemeI’ll try and remember to come back to this post when I see it pop up. But I know from core editor chats that the mover control being hidden, and drag and drop being flaky has been discussed a lot, so I’m sure a ticket to revisit this will land soon.
But the place to look is here: https://github.com/WordPress/gutenberg/issues
Forum: Plugins
In reply to: [Gutenberg] Suggestion: Text Width in Gutenberg Based on ThemeAbsolutely helpful, thank you. Honestly both the movers and drag and drop deserve an iteration. Watch the Gutenberg issues for a ticket soon.
> was wondering if it had been discussed (or was even possible?) to have the dom elements for the Gutenberg controls sit outside the editor-styles-wrapper class element, and get absolute positioned inside editor based on the a Gutenberg wrapper element for the selected/hovered block
The problem I sense here is that when styling the editor, you inadvertently and at times style editor UI as well!
This is CSS bleed and definitely something to address. Yes, it’s technically a challenge, but an important one that is actually being tackled in many small steps.
For starters, with WordPress 5.4 and continued in the Gutenberg plugin, many elements like the block toolbar and the inserter button that sits between blocks has already actually been moved outside the editor-styles-wrapper element as you suggest. It has been moved to a “popover” component, which means it’s no longer subject to CSS bleed. This will likely be further solidified if the iframe PR is able to land.
One aspect is trickier — setup states/placeholders have to be in the DOM itself in order to function. But there are a couple of ways to move forward there, including leveraging “Shadow DOM”.
But yes, the challenge is heard and being tackled!
Forum: Plugins
In reply to: [Gutenberg] Feature Request: Add Keyboard shortcut to toggle Fullscreen modeAwesome Paal, I missed that one! 🤘
Forum: Plugins
In reply to: [Gutenberg] Gutenberg 7.9Same to you!
Forum: Plugins
In reply to: [Gutenberg] Gutenberg 7.9In general the goal is to complete tickets that are attached to a milestone in Github, yes. But as noted, it does happen that things are shuffled around.
Forum: Plugins
In reply to: [Gutenberg] Gutenberg 7.9> I was wondering if you need to close all these before a release is made as they are in the “closed” tab as a ticket, but still have some steps inside which are not finished?
What goes into a release vs. what doesn’t is not always cut and dry. When features are finished and ready to land, they go in. But sometimes bugs are discovered that make them need more time in the oven. Releases should not necessarily be held up based on that.
I would recommend you follow https://github.com/WordPress/gutenberg/releases for hints at the status of a release.
Forum: Plugins
In reply to: [Gutenberg] Why doesn’t default block editor width = content width> The thing is, I think Gutenberg and WordPress in general should start finding a way to implement and take these styles from the themes and apply them in Gutenberg rather than waiting for theme developers and theme owners to have the latest version that supports it. Let’s be real – many themes won’t be updated unfortunately, will we leave them with no WYSIWYG support?
I hear you.
While efforts are underway to make the editor markup behave and appear as closely as possible to the frontend, I’m afraid the opt-in is unlikely to ever go away, as it is impossible to guarantee the theme style will work perfectly in the editor. I believe it should be possible to write a plugin that forces an old theme to opt-in, without having to edit the code.
Forum: Plugins
In reply to: [Gutenberg] code editorStellar!
Forum: Plugins
In reply to: [Gutenberg] Feature Request: Add Keyboard shortcut to toggle Fullscreen modeHi @petersplugins,
Is this something you toggle often? Personally I set my preference and forget about it.
One of the challenges with keyboard shortcuts is that they have to work on Mac, Windows and Linux, and it is often difficult to find one that does and isn’t already taken. Shift Alt F, for example, is a shortcut to the
filigature on a Mac, for example.Forum: Plugins
In reply to: [Gutenberg] Why doesn’t default block editor width = content widthAh yes, that helps! It appears that the “Hello” theme has zero support for the block editor, so you see the fallback styles. So there are a couple of things to try:
– Contact the theme author and ask them to support the block editor.
– Switch to a theme that does support the block editor.
– Use the classic editor.
– Try to add support for the block editor yourself.The 4th item is a bit roundabout, but if you’re feeling adventurous, here’s how it’s done:
1. First, open the
wp-content/themes/hello-elementor/functions.phpfile.2. Search for
add_editor_style, and replace the text so it says this:/* * Editor Style. */ add_theme_support('editor-styles'); add_editor_style( 'editor-style.css' );3. Open the
wp-content/themes/hello-elementor/style-editor.css, and add the following at the end:/* Main column width */ .wp-block { max-width: 960px; } /* Width of "wide" blocks */ .wp-block[data-align="wide"] { max-width: 1080px; } /* Width of "full-wide" blocks */ .wp-block[data-align="full"] { max-width: none; }That should get you the same width of blocks in the editor as they are on the frontend.
Note that if you do edit these files yourself, there is a chance if you update the theme later on, that those changes will have to be reapplied. But given the theme doesn’t have block editor support, I would wager to guess it’s not receiving updates much anymore.
Hope that helps!
Forum: Plugins
In reply to: [Gutenberg] Why doesn’t default block editor width = content widthYour thoughts are much appreciated, and I’m happy there are other options than the block editor that meets your needs.
The reason I ask about which WordPress theme you’re running is that in order for WYSIWYG to land, despite that answer not being the most satisfying, it really is the job of the WordPress theme itself, not the editor.
What you see in the editor in absence of the theme providing the width of the editor, is a line-width that is optimized for readibility, which is about 70 characters per line at the default font size. But this is still recognizing that this width is not a good fit for everyone, which is why the theme can change this.
Forum: Plugins
In reply to: [Gutenberg] Beta, Dev, NightlyThere’s absolutely a place for contributing in a manner that isn’t coding, and your help is much appreciated. There are some guidelines in https://github.com/WordPress/gutenberg/blob/master/docs/contributors/readme.md#sections, for documentation, triage and localization also!
Forum: Plugins
In reply to: [Gutenberg] Gutenberg 7.9Tickets in milestones in Github are sometimes shuffled around as priorities shift and move, and the goal definitely is to release the plugin on a regular cadence with what’s stable and ready to go each week.