Jesse Graupmann
Forum Replies Created
-
Forum: Plugins
In reply to: [Theme Check] REQUIRED: The tags can only contain a call to wp_title().I can’t point you to a file for something not being there when I don’t know what file it should be located in with your own custom structure and layout.
True. And I’m not asking for recommendations on function call locations. Just as much info as you have when you make checks. I went through and noticed that you do glob a chunk of files so you’re telling me that it’s all of them at once – which helps me more than you would think.
But I have a bunch of wp_head() calls… you know, this might be missing the “wp_head ()“. That same space bug.
Ok, that was it. Don’t ask me why those functions were written with an extra space. I write C#, Swift, Objective-C, PHP, javascript and so on. I never add an extra space intentionally.
But in my case, it looks like wp_head (), wp_footer (), wp_title () were all written with an extra space. You can see my frustration when a general rule is telling me it can’t find what I am clearly seeing.
I’d still recommend line numbers for ‘sanitization callback function’ errors along with wp_title() and any other item where you already know the file and/or line number.
I’m new to theme creation, I’m going to make mistakes but this plugin is doing a great job teaching me what to look for and where. So thanks.
Forum: Plugins
In reply to: [Theme Check] Found wrong tag, remove from your style.css header.The custom _s theme I’ve created will never be submitted. It’s for a specific client with specific needs. With that in mind, tags are meaningless but I’d still like to remove the error from Theme Check’s output.
By adding the conditional I believe it will show the actual problem. I personally believe it’s a bug if it is reporting the wrong error, albeit a minor one at that.
When I get some time I’ll submit a pull-request if that helps.
Forum: Plugins
In reply to: [Theme Check] REQUIRED: The tags can only contain a call to wp_title().Thank-you for taking a minute to review this, I appreciate it.
After looking at title-tag it definitely makes sense over wp_title.
As for errors with wp_title(), wp_head() and wp_footer, a major issue in your plugin is that errors can be condensed. Three files may report the same problem but together they receive only one line in the report.
I would suggest for those issues, the filename and/or path to the file is very useful.
In the case of wp_head() & wp_footer I am seeing “Could not find wp_head.” but I have no idea which file it’s referring to. And because it doesn’t exist it’s not something I can search for. I have multiple variations of headers but only a single footer file that contains wp_footer(). I clearly see wp_footer() in my footer.php so to me that error is utter BS — unless I am just not seeing the file it’s referring too (which might not be footer.php???).
For cases where it says I am missing something, I want to see the file it is referring to.
For cases where I am doing something wrong, I want to see the file + line number it is referring to.
This theme was never meant to be submitted anywhere. Regardless, your plugin is the absolute best tool to catch potential errors. I believe with a little extra reporting you could save a ton of extra work by the end user.
Forum: Plugins
In reply to: [Theme Check] Found wrong tag, remove from your style.css header.You plugin has the ability to inform the user of the correct problem. Is it too hard to add another conditional?
Forum: Plugins
In reply to: [Theme Check] REQUIRED: The tags can only contain a call to wp_title().I use PHPStorm and I’m aware of where title tags should be and how to use global search, honestly. But you built a helpful tool and can’t recognize bad UX? Ok, moving on…
The original point is; Some of your functions give line numbers which is super helpful while a few do not. wp_title, wp_head, and wp_footer all say they are REQUIRED but don’t give any information to get straight to the issue they found.
I’m following https://codex.wordpress.org/Plugin_API/Filter_Reference/wp_title and I’m still getting wp_title errors. In a global search everything looks fine to me, until I added the file references. Now it’s telling me there is a problem in files that looked just fine.
<title><?php wp_title ('|', true, 'right'); ?></title>Can you spot the problem? There is a single space between wp_title and (. This seems like a false positive because the correct format is;
<title><?php wp_title('|', true, 'right'); ?></title>My suggestion is; If you have an error, give a line reference or even a file ref for all cases — especially REQUIRED issues.
Forum: Plugins
In reply to: [WordPress Social Login] Takes 50% of all plugins' load timeI added the issue to the GitHub page at https://github.com/miled/wordpress-social-login/issues/68
Forum: Plugins
In reply to: [WordPress Social Login] Takes 50% of all plugins' load time@fadingmusic, I don’t normally trust someone that says not to trust something.
I checked out P3 – Plugin Performance Profiler last night to optimize my own plugins. WP Social Login can take on average 0.5 seconds to load on average – 4.3 seconds on admin-ajax.php. That is ridiculous and it’s such a small portion of the site.
After tweaking and tweaking of my own plugin I applied the same techniques and dropped WP Social to average 0.0596 secs – 4.6 secs on plugin.php.
Things just need to get condensed in that initial plugin file to feel an immediate boost in speed.
register_activation_hook( __FILE__ );that method only needs to be called once and anything admin related should come from a single check and callback
if( is_admin() ) { require_once( WORDPRESS_SOCIAL_LOGIN_ABS_PATH . '/includes/admin/wsl.admin.ui.php' ); // The entry point to WSL Admin interfaces add_action('admin_init', 'wsl_admin_init'); }I hope the author takes a look with P3, but this might require making a pull request on GitHub.
Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeErrorIf you get a chance, I noticed some issues (not related to this plugin) w/ACF 5.2.x so I haven’t upgraded. I would double check against that when you’re done as it seems some things have changed. It may not be that different but it’s worth making sure to QA the latest.
Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeErrorAwesome, thanks!
Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeErrorLooks like it is just happening from Custom Fields -> Custom Fields -> Edit.
I’m sure if you just added a null check on wp.media you could call it a day.
Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeErrorWordPress 4.1.1 w/Advanced Custom Fields Pro 5.1.8
Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeErrorLooks like wp.media is undefined when that function gets called.
wp.media.events.on( 'editor:image-update', function( args ) {Forum: Plugins
In reply to: [RICG Responsive Images] [Bug v2.1.1] Uncaught TypeError/wp-admin/post.php?post=488&action=editForum: Plugins
In reply to: [WordPress Social Login] How to show social profile avatar in a loop?This works for me.
$post = get_post(932); $author_id = $post->post_author; echo the_author_meta('display_name', $author_id);Can you check to see if the author of the post is in fact, not the Admin? Are you setting the user in a different field?
Forum: Plugins
In reply to: [WordPress Social Login] How to show social profile avatar in a loop?You’re welcome.
So what exactly do you want. The title of the post?
$post = get_post(); echo $post->post_title;