John Huebner
Forum Replies Created
-
Forum: Plugins
In reply to: [Autoptimize] Not Aggregating CSS files on MultisiteMore information.
The plugin Classic Editor Addon causes this.
Specifically the act of dequeuing an enqueued style sheet or JS file causes none of the stylesheets after that point to be combined.
This only seems to happen on this multisite for some reason.
I have no idea and I feel like I’m banging my head on a wall. I cannot get this site to combine all CSS and all JS, but only on the main site. All sub sites it works fine.
In the end I’m sure it has to do with the site and not this plugin. Too much going on and the site is old. Needs to be rebuilt
Forum: Plugins
In reply to: [Autoptimize] Not Aggregating CSS files on MultisiteI tried it on another site that is set up for multisite and it’s working.
I have tried deactivating plugins and this did not help so I am assuming that there is something in the theme. There are slight differences in the main site from the sub sites, but not many.
Can you point me in the direction in the code of this plugin where the decision to combine/not combine the CSS is made so I can attempt to debug where this theme is interfering?
Forum: Plugins
In reply to: [Autoptimize] Not Aggregating CSS files on MultisiteIt is combining CSS and JS on all site. It is only combining JS on the main site. All using same theme and plugins. It is only the CSS on site 1 that is not being combined.
Forum: Plugins
In reply to: [What The File] No Longer Showing Template Parts@janinewebbureau more than likely it’s a theme that does not support wp_body_open
Forum: Plugins
In reply to: [What The File] No Longer Showing Template PartsA more permanent solution that you can leave in place, or at least I can because this plugin is only active when I need to work on a site.
if (class_exists('WhatTheFile')) { remove_action('wp_body_open', 'wp_admin_bar_render', 0); }Forum: Plugins
In reply to: [What The File] No Longer Showing Template PartsThis issue.
The WP function wp_admin_bar_render() used to be called on the wp_footer hook.
add_action( 'wp_footer', 'wp_admin_bar_render', 1000 ); // Back-compat for themes not using wp_body_open.And it is now called on the wp_body_open hook
add_action( 'wp_body_open', 'wp_admin_bar_render', 0 );This means that the admin bar is being rendered before this plugin can gather a list of template parts.
Temporary fix can be made by removing the new action
remove_action('wp_body_open', 'wp_admin_bar_render', 0);- This reply was modified 5 years, 3 months ago by John Huebner.
Forum: Plugins
In reply to: [ACF Post-2-Post] Relationship not updated on deleteThis is the way that this plugin has always worked. The relationship fields are only updated when a post is updated and not when a post is deleted.
This plugin works on the acf/update_value hook of relationship and post object fields. This allows my to know exactly what field is being updated.
When a post is deleted there isn’t any way to know that there is a relationship field used on that post. One would need to get all the field groups used on that post and loop over all of the fields to find any post object or relationship fields and then do a search each post on the other end to remove them.
Deleting a post is not the same as editing another post and removing it from the relationship field.
Anyway, this is not something that will be added to this plugin. There are several reasons for this.
One reason is is that if you use the ACF function get_field() to get the relationship field it will not return posts that have been deleted, they are filtered out, as you noticed when editing a post.
In addition to this if you return just the ID values for a relationship field if you use the WP function get_post() or any WP function that works on the post ID it will also not return posts that have been deleted.
This plugin also does nothing different than what ACF does. Create a relationship field that is not bidirectional and add a post to it, then go and delete that post. Checking the database you will find that the post ID is still present in the value of the relationship field where it was added. You would have the same issue with or without using this plugin. There is no mechanism in ACF to check relationship type fields on posts when a post is deleted.
Sorry, I don’t have an answer for you in this case. The tool or other plugin that is being used to show the ACF field value would need to make sure the posts exist before attempting to show them and this would be true with or without the use of this plugin being active.
Forum: Plugins
In reply to: [ACF Options Page Admin] Field losing inputThis issue had to do with multisite and only super admins being allowed unfiltered HTML.
The most recent topic on this over on the ACF support forum is here https://support.advancedcustomfields.com/forums/topic/script-tags-stripped-from-text-area-for-admin-user/
You may be able to find other older topics there as well.
Forum: Plugins
In reply to: [ACF Options Page Admin] Field losing inputWP could be stripping out the html depending on what type of user is saving and what type of field it is.
Is the user that is having the problem an admin? editor? something else?
Are you using mulitsite?Forum: Plugins
In reply to: [ACF Options Page Admin] Field losing inputThis plugin would not have any effect on the saving of fields. It only supplies an interface for creating the options pages. All fields are still managed by ACf.
Forum: Developing with WordPress
In reply to: Escape Placeholder not RemovedI haven’t a clue what was happening with this but I tested it today and everything is working as expected.
You can disregard my previous comment. Problem resolved. jQuery migrate was not being enqueued and this caused the errors.
- This reply was modified 5 years, 4 months ago by John Huebner.
I am getting the similar errors
Uncaught TypeError: e.indexOf is not a function load jQuery <anonymous> .../counter-number-showcase/assets/js/waypoints.min.js?ver=5.6.2:8 <anonymous> .../counter-number-showcase/assets/js/waypoints.min.js?ver=5.6.2:8 <anonymous> .../counter-number-showcase/assets/js/waypoints.min.js?ver=5.6.2:8 jquery.min.js:2:84831Forum: Plugins
In reply to: [Classic Editor] Changes you made may not be saved.Thank you for the link @spikeuk1 now I can watch that too.
Forum: Plugins
In reply to: [Classic Editor] Changes you made may not be saved.Yep, I can confirm, only on pages, posts and CPTs work fine.