hollymcr

Thank you!

Question: You say idemopotency_key is set to {hash}:{order number}-{attempts}, but what is {hash} generated from?

From a glance at the code, {hash} seems to be based on the site URL, so should stay the same for all my site transactions. But is there any reason for it to be so?

Thought: What would be the implication of having idemopotency_key set to md5(“$site:$order_number”) so that, regardless of order number structure, the result was always 32 chars? You could then set idempotency_key to {hash}-{attempts} and (for any reasonable number of attempts!) always remain below 45 chars. That would make it compatible with any plugin which changed the order number structure.

I can see an advantage of the current structure when looking at the logs but as far as I can see the actual order number is always present within the data structure that contains the idempotency_key.

Or maybe a better fix: if idempotency_key ever exceeds 45 chars, do something to make force it under 45 chars, eg (untested):

public function get_idempotency_key( $key_input = '' ) {

    if ( '' === $key_input ) {
        $key_input = uniqid( '', false );
    }

    $hash_source = get_option( 'siteurl' );
    if ( strlen( $key_input ) > 12 ) {
        // As things stand, idempotency_key will exceed 45 chars
        // Therefore include $key_input in the md5 hash (to ensure uniqueness)
        // and shorten $key_input to make everything fit
        $hash_source .= ':' . $key_input;
        $key_input = substr( $key_input, -12 );
    }
    return apply_filters( 'wc_square_idempotency_key', md5( $hash_source ) . ':' . $key_input );
}

That should result in no changes to idempotency_key for sites where it already works, but fix any that don’t because of a long order number. (Can you see any problems with it?)

Still don’t understand why it used to work then stopped though, as I have always had this order number structure. Maybe something was letting >45 char idempotency_key values work, then started to enforce the limit?

I’ve had to disable the cache because of this issue – any advice on bow to investigate this?

Update: It looks like the code is being loaded (from view->source on the dashboard). Furthermore it looks like a JS exception is being thrown:
Uncaught ReferenceError: datelabel is not defined
in the code:
xaxis: {ticks : datelabel, tickDecimals : 0}

Debugging it past that point I’m stuck… Where does datelabel get set?