eitanc
Forum Replies Created
-
Forum: Plugins
In reply to: [IP2Location Redirection] Add an option to disable specific ruleThanks!
Forum: Plugins
In reply to: [Companion Auto Update] Several thingsAlso notice – at the GUI you state “Be notified of plugins that have not been tested with your current version of WordPress.” but at the email the text is “You have plugins on your WordPress site at https://food.caspi.org.il that have not been tested with the latest 3 major releases of WordPress.
The following plugins have not been tested with WordPress 5.5.1:”There is a mismatch here, the meaning is not identical – “not been tested with your current version of WordPress” is not exactly “have not been tested with the latest 3 major releases of WordPress”. Be accurate and match what the code is doing.
Forum: Plugins
In reply to: [Companion Auto Update] Several thingsAlso, you send the outdated items email every few hours… this is bothering… please set a default of, say, once a week and let users change the recurrence schedule, or only once.
Thanks.Forum: Plugins
In reply to: [Companion Auto Update] Several thingsAdding:
In the email, for plugins (and I guess for other types) that are *not* in the WP plugins site you show:
”
– Post Notification tested up to:
”
Instead of an empty values put a system text like “This <object-type-name> was not found in the WordPress web site, hence it may either be a non-public <object-type-name> or it is not being actively developed anymore – which makes it a high risk for functional and/or security issues to your site, so you should consider disabling and deleting it from your site”Thanks.
Thanks, but for what you wrote – it looks like I need to have the paid version, right?
Great, thanks. I guess you will mention this fix in the release notes text of the relevant version, right?
Forum: Plugins
In reply to: [Advanced GeoIP Redirect] Enhancements requestsAlso, please make the rule base adjustable so it will have priorities (processing top to bottom). This will make the processing order more understandable and clear to users and for troubleshooting.
Thanks.Forum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct targetBetter on a non-polylang site for now. Looks OK now but… – accessing directly to a deeper specific link, like site.com/page1 still run the redirect… which is not good (my rule is asking a redirect from the root of the site).
It is as if the rule is ending with “*”, meaning apply to also anything inside the base link.
You really should do proper QA before publishing a plugin.
Also – test it on WP 5.5, my current WP version (there is a warning at the WP plugin page that it is not supporting the current WP version), and add release notes and the new version to https://wordpress.org/plugins/adv-geoip-redirect/#developersForum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct targetOK, the exactly same thing happens on a simple site, non-polylang, I redirected the root to a page and I see to many redirects, again from the target to the target.
Please QA this.Forum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct target1. I changed the “When visit” to be https://vsec.co.il/ and it is still the same.
2. OK, now the debug.log was created and it shows multiple unneeded same redirects, but false ones from target to target… strange.
Also, you redirect every html object (e.g. css), while you should redirect only the first requestThe rule it to go to https://vsec.co.il/he/about-heb/ from https://vsec.co.il/
Debug Log : 2020-08-13 07:38:21 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/en/ Debug Log : 2020-08-13 07:38:21 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:38:42 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/wp-content/themes/arilewp/assets/css/bootstrap.css.map/ Debug Log : 2020-08-13 07:38:42 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/wp-content/themes/arilewp/assets/js/bootstrap.js.map/ Debug Log : 2020-08-13 07:39:22 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:23 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:24 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:24 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:25 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:26 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:27 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:28 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:28 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:29 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:31 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:31 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:32 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:33 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:34 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:35 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:37 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:38 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:40 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:40 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:41 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:42 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:43 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:44 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:44 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:46 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:47 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:48 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:49 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:50 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:51 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:52 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:52 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:54 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:54 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:55 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:56 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:57 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:39:58 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:40:00 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:40:01 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:40:02 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/ Debug Log : 2020-08-13 07:40:55 Visitor IP x.x.x.x Redirection succeeded! To https://vsec.co.il/he/about-heb/ From https://vsec.co.il/he/about-heb/3. Also it will be good to change the display and log flow to match reality – meaning from source to target. Today it is the other way round, which is confusing.
4. I have a special situation in this site – it is using a plugin named “Polylang”, to support multiple languages, I have two, Hebrew and English. It uses as setting of “The language is set from the directory name in pretty permalinks
Example: https://vsec.co.il/en/my-post/” and “Detect browser language” is disabled to prevent it from redirecting by the user-agent language, not to harm this plugin.
Can you test it with this plugin?
I will test your plugin in a non-polylang site and report back hereForum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct targetI will try tomorrow, it is late here now. Will update you.
But what about the debug log file?Forum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct targetForum: Plugins
In reply to: [Advanced GeoIP Redirect] Too many redirects to the correct targetI cannot upload files here
Forum: Plugins
In reply to: [Companion Auto Update] “Updating is globally disabled”I watched the text now and it doesn’t mention that it will also send WP emails for plugins and theme (from version 5.5), so it really needs update (with note about what changed at WP 5.5), Thanks.
Forum: Plugins
In reply to: [Companion Auto Update] “Updating is globally disabled”Also consider adding a text near this global disable notice, to direct folks to the fact they need to clear this line from wp-config to re-enable the plugin’s activity.