edow

I’m extending the form and came with the following idea to show only the “regio” which belongs to the right “land”:

<form name="sidebarform" onChange="document.forms.sidebarform.submit();">
		<input type="hidden" name="paged" value="1">

		<?php
		if (is_category()){
		  $cat = get_query_var('cat');
		  $yourcat = get_category ($cat);
		}
		$tag_IDs = array();
		query_posts('category_name='.$yourcat->slug);
		if (have_posts()) : while (have_posts()) : the_post();
		  $posttags = get_the_tags();
		  if ($posttags):
			foreach($posttags as $tag) {
			if (!in_array($tag->term_id , $tag_IDs)):
			   $tag_IDs[] = $tag->term_id;
			   $tag_names[$tag->term_id] = $tag->name;
			   $tag_slug[$tag->term_id] = $tag->slug;
			 endif;
			}
		  endif;
		endwhile; endif;
		wp_reset_query();

		$getTag = $_GET["tag"];
		if ($getTag == '') {
			$tag_showall = 'checked';
			}
		if (!empty($tag_IDs)){
			echo '<h3>Het meest geschikt voor</h3>';
			echo '<input type="radio" name="tag" value="" '.$tag_showall.'> Alles weergeven<br>';
		}
		foreach($tag_IDs as $tag_ID){
			$checked = $tag_slug[$tag_ID];
			echo '<input type="radio" name="tag" value="'.$checked.'"' ;
			if((isset($_GET["tag"])) && $_GET["tag"] == $checked) {
			echo ' checked="checked"';
			}
			echo '> '.$tag_names[$tag_ID].'<br>';
		}
		?>

		<div class="margin25px"></div>

		<?php
			$land = $_GET["land"];
			$regio = $_GET["regio"];

			if ($land == 'all' OR $land == '') {
			$land_showall = 'checked';
			}
			elseif ( $land == 'nederland' ) {
			$landNL = 'checked';
			}
			elseif ( $land == 'belgie' ) {
			$landBE = 'checked';
			}
			if ($regio == 'all' OR $regio == '') {
			$regio_showall = 'checked';
			}
			elseif ( $regio == 'groningen' ) {
			$regioNL1 = 'checked';
			}
			elseif ( $regio == 'friesland' ) {
			$regioNL2 = 'checked';
			}
			elseif ( $regio == 'drenthe' ) {
			$regioNL3 = 'checked';
			}
			elseif ( $regio == 'overijssel' ) {
			$regioNL4 = 'checked';
			}
			elseif ( $regio == 'flevoland' ) {
			$regioNL5 = 'checked';
			}
			elseif ( $regio == 'gelderland' ) {
			$regioNL6 = 'checked';
			}
			elseif ( $regio == 'utrecht' ) {
			$regioNL7 = 'checked';
			}
			elseif ( $regio == 'noord-holland' ) {
			$regioNL8 = 'checked';
			}
			elseif ( $regio == 'zuid-holland' ) {
			$regioNL9 = 'checked';
			}
			elseif ( $regio == 'zeeland' ) {
			$regioNL10 = 'checked';
			}
			elseif ( $regio == 'noord-brabant' ) {
			$regioNL11 = 'checked';
			}
			elseif ( $regio == 'limburg' ) {
			$regioNL12 = 'checked';
			}
			elseif ( $regio == 'namen' ) {
			$regioBE1 = 'checked';
			}
			elseif ( $regio == 'waals-brabant' ) {
			$regioBE2 = 'checked';
			}
			elseif ( $regio == 'west-vlaanderen' ) {
			$regioBE3 = 'checked';
			}
		?>

		<h3>Land</h3>
			<input type="radio" name="land" value="all" <?php echo $land_showall; ?>> Alles weergeven<br>
			<input type="radio" name="land" value="nederland" <?php echo $landNL; ?>> Nederland<br>
			<input type="radio" name="land" value="belgie" <?php echo $landBE; ?>> België

			<?php
		if ( $land == 'all' OR $land == '' ) {
		echo '<div class="margin25px"></div>';
		echo '<h3>Regio</h3>';
		echo '<input type="radio" name="regio" value="all" '.$land_showall.'> Alles weergeven<br>';
		echo '<input type="radio" name="regio" value="groningen" '.$regioNL1.'> Groningen<br>';
		echo '<input type="radio" name="regio" value="friesland" '.$regioNL2.'> Friesland<br>';
		echo '<input type="radio" name="regio" value="drenthe" '.$regioNL3.'> Drenthe<br>';
		echo '<input type="radio" name="regio" value="overijssel" '.$regioNL4.'> Overijssel<br>';
		echo '<input type="radio" name="regio" value="flevoland" '.$regioNL5.'> Flevoland<br>';
		echo '<input type="radio" name="regio" value="gelderland" '.$regioNL6.'> Gelderland<br>';
		echo '<input type="radio" name="regio" value="utrecht" '.$regioNL7.'> Utrecht<br>';
		echo '<input type="radio" name="regio" value="noord-holland" '.$regioNL8.'> Noord-Holland<br>';
		echo '<input type="radio" name="regio" value="zuid-holland" '.$regioNL9.'> Zuid-Holland<br>';
		echo '<input type="radio" name="regio" value="zeeland" '.$regioNL10.'> Zeeland<br>';
		echo '<input type="radio" name="regio" value="noord-brabant" '.$regioNL11.'> Noord-Brabant<br>';
		echo '<input type="radio" name="regio" value="limburg" '.$regioNL12.'> Limburg<br><br>';
		echo '<input type="radio" name="regio" value="namen" '.$regioBE1.'> Namen<br>';
		echo '<input type="radio" name="regio" value="waals-brabant" '.$regioBE2.'> Waals-Brabant<br>';
		echo '<input type="radio" name="regio" value="west-vlaanderen" '.$regioBE3.'> West-Vlaanderen<br>';
		}

		elseif ( $land == 'nederland' ) {
		echo '<div class="margin25px"></div>';
		echo '<h3>Regio</h3>';
		echo '<input type="radio" name="regio" value="all" '.$regio_showall.'> Alles weergeven<br>';
		echo '<input type="radio" name="regio" value="groningen" '.$regioNL1.'> Groningen<br>';
		echo '<input type="radio" name="regio" value="friesland" '.$regioNL2.'> Friesland<br>';
		echo '<input type="radio" name="regio" value="drenthe" '.$regioNL3.'> Drenthe<br>';
		echo '<input type="radio" name="regio" value="overijssel" '.$regioNL4.'> Overijssel<br>';
		echo '<input type="radio" name="regio" value="flevoland" '.$regioNL5.'> Flevoland<br>';
		echo '<input type="radio" name="regio" value="gelderland" '.$regioNL6.'> Gelderland<br>';
		echo '<input type="radio" name="regio" value="utrecht" '.$regioNL7.'> Utrecht<br>';
		echo '<input type="radio" name="regio" value="noord-holland" '.$regioNL8.'> Noord-Holland<br>';
		echo '<input type="radio" name="regio" value="zuid-holland" '.$regioNL9.'> Zuid-Holland<br>';
		echo '<input type="radio" name="regio" value="zeeland" '.$regioNL10.'> Zeeland<br>';
		echo '<input type="radio" name="regio" value="noord-brabant" '.$regioNL11.'> Noord-Brabant<br>';
		echo '<input type="radio" name="regio" value="limburg" '.$regioNL12.'> Limburg';
		}

		elseif ( $land == 'belgie' ) {
		echo '<div class="margin25px"></div>';
		echo '<h3>Regio</h3>';
		echo '<input type="radio" name="regio" value="all" '.$regio_showall.'> Alles weergeven<br>';
		echo '<input type="radio" name="regio" value="namen" '.$regioBE1.'> Namen<br>';
		echo '<input type="radio" name="regio" value="waals-brabant" '.$regioBE2.'> Waals-Brabant<br>';
		echo '<input type="radio" name="regio" value="west-vlaanderen" '.$regioBE3.'> West-Vlaanderen<br>';
		}
		?>
		</form>

It’s working, but there’s one problem. If I click on “belgie” it shows the “regio” which are in “belgie”. For example I click on “namen” the URL will be like /?land=belgie&regio=namen. That’s alright.
But when after that I click on “nederland” (so another “land”) the URL become /?land=nederland&regio=namen. Which is wrong, because “namen” is not in “nederland”.

Because of this the posts aren’t filtering the right way. What I want is when I change the “land” the “regio” will be “all”.
So, every time “land” is clicked the URL should be /?land=belgie&regio=all (if clicked on the land “belgie”) OR /?land=nederland&regio=all (if clicked on the land “nederland) OR /?land=all&regio=all (if clicked on the land “all”).

I hope I’m clear in what I want. I tried a lot of things, even with hidden fields, but only the radio buttons change and not the URL.

Is it possible and if so, what do I do wrong?

Thanks for your reply. Instead of an empty string I changed the value to ?land=all.

I used your suggested code in functions.php, but a little different:

function wpa_filter_home_query( $query ){
	if( $query->is_main_query()
    && isset( $_GET['land'] )
	&& isset( $_GET['provincie'] )
	&& $_GET['land'] != "all"
	&& $_GET['provincie'] != "all" ) {
		$meta_query = array(
		'relation' => 'AND',
			array(
                'key' => 'land',
                'value' => array( $_GET['land'] )
            ),
			array(
                'key' => 'provincie',
                'value' => array( $_GET['provincie'] )
            )
        );
        $query->set( 'meta_query', $meta_query );
    }
	elseif( $query->is_main_query()
	&& isset( $_GET['land'] )
	&& $_GET['land'] != "all" ) {
        $meta_query = array(
			array(
                'key' => 'land',
                'value' => array( $_GET['land'] )
            )
        );
        $query->set( 'meta_query', $meta_query );
    }
	elseif( $query->is_main_query()
	&& isset( $_GET['provincie'] )
	&& $_GET['provincie'] != "all" ) {
        $meta_query = array(
			array(
                'key' => 'provincie',
                'value' => array( $_GET['provincie'] )
            )
        );
        $query->set( 'meta_query', $meta_query );
    }
}
add_action( 'pre_get_posts', 'wpa_filter_home_query' );

Is && $_GET['land'] != "all" used alright? Or should I use another IF statement? It seems to work right now, but I want a clean code.

In my sidebar I used the following code:

$land = $_GET["land"];
$provincie = $_GET["provincie"];
if ($land == 'all') {
$showall_land = 'checked';
}

<h3>Land</h3>
<input type="radio" name="land" value="all" <?php echo $showall_land; ?>> Alles weergeven<br>}

And if clicked “Alles weergeven” the url is /?land=all.

It seems to work properly, but I need to test it a little bit more. Because the string isn’t empty I guess I don’t need to unset the query anymore?

Thanks again!! And hopefully you can confirm my code above is properly and so the form is finished 🙂

As you suggested I tried the hidden field option.

<input type="hidden" name="paged" value="1">

This works for me.

Before that I made a special sidebar function for the 404.php page, but that isn’t necessary anymore it seems. It was this code:

$tag = $_GET["tag"];
$land = $_GET["land"];
$provincie = $_GET["provincie"];

if (!empty($tag)) {
	$showSidebar = 'category';
	}
elseif (!empty($land)) {
	$showSidebar = 'category';
	}
elseif (!empty($provincie)) {
	$showSidebar = 'category';
	}
else{
	$showSidebar = '';
	}

get_sidebar($showSidebar);

So, that problem is now solved.

The last problem with this form is that when I want to show for example all the countries (“land”) I need the string ?land= to disappear from the url.

I thought it to do like this:

<input type="radio" name="land" value=""> Show all<br>

but that doesn’t work. With the tag it already does automatically, but it isn’t working for other keys. The url becomes /?land and the checkbox isn’t checked. So, or the string needs te be removed from the url (so it doesn’t filter and thus shows all the countries) or the string needs to be /?land=all and then the query needs to show all the countries.

How can I handle this?

Indeed I use the previous_posts_link and the next_posts_link links.
I think I wasn’t clear about it, but these buttons do take the URL parameters to the next page (my example was wrong).

I’ve tested it a little bit more and now I it does this (there are 9 posts per page):

1. With more then 9 posts I use the next_posts_link link and it takes the URL parameter to the next page and that’s working good.
2. When I’m on page 2 and I click on the “land” with value “Nederland” it filters, because there are 10 “lands” with the value “Nederland”, but it shows on page 2 the 10th post (and it shows the previous_posts_link), so I think that’s why on page 2 with 9 posts or less with a certain value it gives the 404 error.
3. When I click on a value with for example 2 posts attachted to it (when I’m on page 2) I get the 404 error.

So, when I’m on the page /cat/activiteit/page/2/ and I start to filter and there are enough posts it’s working, but it shows the last posts and you need to click on the previous link to see the rest. And if there are for example 2 posts it gives the 404 error.

Hi,

No problem and I hope you had a nice couple of days off 🙂

If /?land= is in the url parameter then zero results are given instead of all the results, so when I click the “Show All” radio button then I need the parameter /?land= to disappear. I’ll try what you suggested.

In the meanwhile another problem occurs 🙁
When I’m on page 2 in the category (/page/2/) and I check something a 404 error appears. I found out I need to add the “paged” parameter to the query.
I thought to do it like this:

function wpa_filter_home_query( $query ){
	$paged = ( get_query_var('paged') ) ? get_query_var('paged') : 1;
	if( $query->is_main_query()
    && isset( $_GET['land'] )
	&& isset( $_GET['provincie'] ) ) {
		$meta_query = array(
		'relation' => 'AND',
			array(
                'key' => 'land',
                'value' => array( $_GET['land'] ),
				'paged' => $paged
            ),
			array(
                'key' => 'provincie',
                'value' => array( $_GET['provincie'] ),
				'paged' => $paged
            )
        );
        $query->set( 'meta_query', $meta_query );

But this still gives a 404 error on page 2 of the category.

I also tried 'paged' => get_query_var( 'paged' ) but without succes.

So the form is almost working as I want, but not on page 2, 3 and so on.

With one array it works when I click on “provincie” without the need of selecting something else.

function wpa_filter_home_query( $query ){
    if( $query->is_main_query()
    && isset( $_GET['provincie'] ) ) {
        $meta_query = array(
			array(
                'key' => 'provincie',
                'value' => array( $_GET['provincie'])
            )
        );
        $query->set( 'meta_query', $meta_query );
    }
}
add_action( 'pre_get_posts', 'wpa_filter_home_query' );

I think I have the solution for the creating of the url paramter based on multiple custom fields. It looks like this code is working fine:

function wpa_filter_home_query( $query ){
    if( $query->is_main_query()
	&& isset( $_GET['land'] )
    && isset( $_GET['provincie'] ) ) {
        $meta_query = array(
            array(
                'key' => 'land',
                'value' => array( $_GET['land'])
            ),
			array(
                'key' => 'provincie',
                'value' => array( $_GET['provincie'])
            )
        );
        $query->set( 'meta_query', $meta_query );
    }
}
add_action( 'pre_get_posts', 'wpa_filter_home_query' );

It’s another approach then you suggested, but I thought I’ll give it a try.