Demonslay335

Ah, yes, that seems to be the issue.

No index defined!

I’ve compared with another WordPress site’s database and confirmed name should be the PRIMARY KEY. Not sure how the index was not added during install of the plugin, all other WordFence tables have their indexes.

Thank you for the prompt response, this should fix the issue (I have to first consolidate the duplicate keys before MySQL will allow me to add the index). I’ll mark this as resolved and re-open it if I run into further issues.

Thanks!

ambruck,

Please be sure that you have edited the correct file. It looks like, from the line number, it may have not taken your change properly. The line number for the error stayed the same (537) even with the addition of code, which should have pushed the afflicted line down.

Here is what the whole function should look like.

/**
 * Load Google Maps API
 *
 * @description: Determine if Google Maps API script has already been loaded
 * @since      : 1.0.3
 * @return bool $multiple_google_maps_api
 */
public function check_for_multiple_google_maps_api_calls() {

	global $wp_scripts;

	$multiple_google_maps_api = false;

	/**
	*	Prevent crashes for guests
	*	@link	https://wordpress.org/support/topic/invalid-argument-25
	*/
	if(is_null($wp_scripts) || is_null($wp_scripts->registered)){

		return $multiple_google_maps_api;

	}

	//loop through registered scripts
	foreach ( $wp_scripts->registered as $registered_script ) {

		//find any that have the google script as the source, ensure it's not enqueud by this plugin
		if ( strpos( $registered_script->src, 'maps.googleapis.com/maps/api/js' ) !== false && strpos( $registered_script->handle, 'google-maps-builder' ) === false ) {

			$multiple_google_maps_api = true;
			//ensure we can detect scripts on the frontend from backend; we'll use an option to do this
			if ( ! is_admin() ) {
				update_option( 'gmb_google_maps_conflict', true );
			}

		}

	}

	//Ensure that if user resolved conflict on frontend we remove the option flag
	if ( $multiple_google_maps_api === false && ! is_admin() ) {
		update_option( 'gmb_google_maps_conflict', false );
	}

	//returns boolean
	return $multiple_google_maps_api;
}

If you continue to have issues, I can send you the file.

nimeck,

My proposed patch would look as follows:

if(is_null($wp_scripts) || is_null($wp_scripts->registered)){

	return $multiple_google_maps_api;

}

//loop through registered scripts
foreach ( $wp_scripts->registered as $registered_script ) {
	// Loop code...
}

Note that the code I suggested goes before the loop, to prevent the loop from crashing if the variable is NULL unexpectedly.