daymobrew

So as not to override cmb2 2.10.1 I put the develop branch version in wp-content/plugins/CMB2-develop directory.

I downloaded the zip from github. develop branch has version number 2.10.0.

For hpos add-on I downloaded the zip from github and activated that as a plugin. I’ve been trying to debug in VSC but my breakpoints are ‘unverified’ and ignored so I just began adding error_log() calls to verify the code is being run. The CMB2_Woo_HPOS_Orders::_construct function. I then added error_log() to init_hooks but that did not run. I could find the do_action( 'cmb2_init_hooks' ) call anywhere in CMB2 2.10.1 or CMB2 develop. Similar issue for the add_filter() calls to cmb2_set_box_object_type and cmb2_set_box_object_type – cannot find the matching apply_filters() calls.

• This reply was modified 2 years, 8 months ago by daymobrew. Reason: Add info about add_filter

Code: https://pastebin.com/PDFBNgaQ

To set up HPOS in WooCommerce: https://woocommerce.com/document/high-performance-order-storage/#section-2

Essentially: WooCommerce/Settings/Advanced/Features then click ‘High performance order storage (new)’. I also uncheck ‘Keep the posts and orders tables in sync (compatibility mode).’

Yes, still an issue.

CMB2_Hookup::save_post() and CMB2_Hookup::can_save() are being run on save but not the ‘cmb2_override_meta_save‘ filter as can_save() returns false.

I have the following filters running successfully:

// To read from custom table.
add_filter( 'cmb2_override_meta_value', 'dcwd_cmb2_override_meta_value', 10, 4 );
// To get past can_save() checks. Returns true when my 2 fields are in $_POST.
add_filter( 'cmb2_can_save', 'dcwd_cmb2_can_save', 10, 2 );

but my ‘cmb2_override_meta_save‘ filter is not running. I also have ‘cmb2_override_tracking_number_meta_save‘ and ‘cmb2_override_tracking_url_meta_save‘ (to match field IDs) but they don’t run either.

Partial code: https://pastebin.com/sEQr7Rcu

• This reply was modified 2 years, 8 months ago by daymobrew. Reason: Make code comments easier to read

Is this better? (I have a feeling it isn’t).

https://github.com/CMB2/CMB2/pull/1495

If not then I’ll submit as a GitHub Issue.

I’ve been going through the includes/CMB2_Hookup.php code. I can see that save_post() is not being called. Looking through the WooCommerce code maybe ‘woocommerce_process_shop_order_meta’ needs to be hooked to.

add_action( 'woocommerce_process_shop_order_meta', array( $this, 'save_post' ), 10, 2 );

Adding this helps a lot! can_save() gets run though $type is not set so it fails. It’s not set because save_post() cannot determine the post type.

I could use the ‘cmb2_can_save‘ filter to override can_save()’s false result but that seems risky.

I experimented a bit and found that get_current_screen()->id == 'woocommerce_page_wc-orders' so the metabox now shows.

I’ll experiment a bit more before marking this as resolved.