Backpack.Studio
Forum Replies Created
-
Hi @mattmary,
unfortunately you did not provide any information how you were able to produce any timeout. We are unable to repeat any timeout. There is no any logs on server about timeouts either. You did not provide even the URL of query and request type (POST, GET, etc). We are unable to guess about what timeout you are talking at all. This could happen on your side, not on server side.
Prashant Rai wrote:
Since the image is a decorative image, we have left the alt attribute empty, so that it will be “invisible” for the screen readers.
Please note, that this is hard coded into plugin and site-owner does not have proper control over it. With an update fix in code will be overwritten.
If formula is used on many pages (for example product pages on e-store), this triggers huge amount of SEO errors and reduces drastically SEO ranking.
The product you provide should help to solve problems, not to cause new ones.
Thank you for response.
As mentioned above, version of WordPress is 5.6, the latest. Plugin version is also the latest – 0.4.1.
As you see from my post above, the code has bad logic, no any validation of external variables, also an unnecessary variable is defined. On such case if you use external variables, you have to validate these before using.
It’s irrelevant if you can or cannot reproduce this error, because your code have used has an open door for errors! Please fix the code.
Seems to be invalid code.
/** * Modify menu page urls */ public static function modify_menu_urls(){ global $menu, $submenu; foreach( $submenu['dw-specs'] as $k => $d ){ if( $d[2] == 'dw-specs-new' ){ $submenu['dw-specs'][$k][2] = 'post-new.php?post_type=specs-table'; break; } } }Variable $menu not used at all. Why it is defined at all?
Why there is no check if function is called too earlier on why it’s called at admin login etc?
Code below avoids errors:
/** * Modify menu page urls */ public static function modify_menu_urls(){ global $submenu; if(is_array($submenu) && isset($submenu['dw-specs'])){ foreach( $submenu['dw-specs'] as $k => $d ){ if( $d[2] == 'dw-specs-new' ){ $submenu['dw-specs'][$k][2] = 'post-new.php?post_type=specs-table'; break; } } } }Related code:
foreach( $submenu['dw-specs'] as $k => $d ){ if( $d[2] == 'dw-specs-new' ){ $submenu['dw-specs'][$k][2] = 'post-new.php?post_type=specs-table'; break; } }