awhig

Hi,

I forgot to mention that w3-total-cache/wp-content/object-cache.php has to also be updated with the new function parameters as well. This file then gets copied into the wp-content folder of the site, to activate object caching.

Rich

Thank you.

Rich

W3TC still works, in that your site will still function.

The Object cache though does not work for anything that tests the $found parameter to determine an object was actually found in the cache. Any performance gain the object cache offers is lost.

The fix is rather simple.

In lib/W3/ObjectCacheBridge.php

change the get function to (line 27):

function get($id, $group = 'default', $force = false, &$found = null) {
        $cache = $this->_get_engine($group);
        return $cache->get($id, $group, $force, $found);
    }

In lib/W3/ObjectCache.php (line 153). I wanted to minimize code changes, so I avoided trying to rewrite this method…

function get($id, $group = 'default', $force = false, &$found = null) {
        if ($this->_debug) {
            $time_start = w3_microtime();
        }

        $key = $this->_get_cache_key($id, $group);
        $internal = isset($this->cache[$key]);

        if ($internal) {
            $value = $this->cache[$key];
            $found = true;
        } elseif ($this->_caching &&
                  !in_array($group, $this->nonpersistent_groups) &&
                    $this->_check_can_cache_runtime($group)) {
            $cache = $this->_get_cache(null, $group);
            $v = $cache->get($key);
            if (is_array($v) && $v['content'] != null)
            {
                $value = $v['content'];
                $found = true;
            }
            else
                $value = false;
        } else {
            $value = false;
        }

        if ($value === null) {
            $value = false;
        }

        if (is_object($value)) {
            $value = clone( $value );
        }

        $this->cache[$key] = $value;
        $this->cache_total++;

        if ($found){
            $cached = true;
            $this->cache_hits++;
        } else {
            $found = false;
            $cached = false;
            $this->cache_misses++;
        }

        /**
         * Add debug info
         */
        if ($this->_debug) {
            $time = w3_microtime() - $time_start;
            $this->time_total += $time;

            if (!$group) {
                $group = 'default';
            }

            $this->debug_info[] = array(
                'id' => $id,
                'group' => $group,
                'cached' => $cached,
                'internal' => $internal,
                'data_size' => ($value ? strlen(serialize($value)) : ''),
                'time' => $time
            );
        }

        return $value;
    }

I just reverted back to version 3.0, and I’m having the same issue.

I believe, the issue is with a change in the WPML plugin as I’m running a beta version of it to fix a catastrophic bug in the latest release version has. Hopefully this will be resolved with the final release of the WPML bug.

Rich