allanext

Hi @swetakumari,

any updates on this issue ?

Thank you,
allanext

Sorry for getting back only now.

I’ve just created 3 anchors to each tab, as you can see if you click on the first anchor (by default open) it scrolls down (a bit too much but it can be fixed with css). If you click on the anchors 2 and 3 nothing happens, shouldn’t it scroll to the anchor and open the tab selected ?

This is the code of the page:

<!-- wp:html -->
<div class="entry-content">
<a href="/test-anchor-on-tabs#anchor1">Anchor 1</a>
<a href="/test-anchor-on-tabs#anchor2">Anchor 2</a>
<a href="/test-anchor-on-tabs#anchor3">Anchor 3</a>
</div>
<!-- /wp:html -->

<!-- wp:paragraph -->
<p>Let's put a vertical spacer</p>
<!-- /wp:paragraph -->

<!-- wp:spacer {"height":286} -->
<div style="height:286px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:uagb/tabs {"block_id":"f9e6c8ed","tabActive":2} -->
<div class="wp-block-uagb-tabs uagb-block-f9e6c8ed uagb-tabs__wrap uagb-tabs__hstyle1-desktop uagb-tabs__vstyle6-tablet uagb-tabs__vstyle6-mobile" data-tab-active="0"><ul class="uagb-tabs__panel uagb-tabs__align-left"><li class="uagb-tab uagb-tabs__active"><a href="#uagb-tabs__tab0" class="uagb-tabs-list uagb-tabs__icon-position-left" data-tab="0"><span>Tab 1</span></a></li><li class="uagb-tab "><a href="#uagb-tabs__tab1" class="uagb-tabs-list uagb-tabs__icon-position-left" data-tab="1"><span>Tab 2</span></a></li><li class="uagb-tab "><a href="#uagb-tabs__tab2" class="uagb-tabs-list uagb-tabs__icon-position-left" data-tab="2"><span>Tab 3</span></a></li></ul><div class="uagb-tabs__body-wrap"><!-- wp:uagb/tabs-child {"block_id":"6b27d634","tabActive":2,"tabHeaders":["Tab 1","Tab 2","Tab 3"]} -->
<div class="wp-block-uagb-tabs-child uagb-tabs__body-container uagb-tabs__inner-tab uagb-inner-tab-0" id="anchor1"><div class="uagb-blocks__6b27d634 uagb-tabs__body" aria-labelledby="uagb-tabs__tab0"><!-- wp:paragraph -->
<p>Content Tab 1</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:uagb/tabs-child -->

<!-- wp:uagb/tabs-child {"block_id":"9d8537cc","id":1,"tabActive":2,"tabHeaders":["Tab 1","Tab 2","Tab 3"]} -->
<div class="wp-block-uagb-tabs-child uagb-tabs__body-container uagb-tabs__inner-tab uagb-inner-tab-1" id="anchor2"><div class="uagb-blocks__9d8537cc uagb-tabs__body" aria-labelledby="uagb-tabs__tab1"><!-- wp:paragraph -->
<p><meta charset="utf-8">Content Tab 2</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:uagb/tabs-child -->

<!-- wp:uagb/tabs-child {"block_id":"a8895db2","id":2,"tabActive":2,"tabHeaders":["Tab 1","Tab 2","Tab 3"]} -->
<div class="wp-block-uagb-tabs-child uagb-tabs__body-container uagb-tabs__inner-tab uagb-inner-tab-2" id="anchor3"><div class="uagb-blocks__a8895db2 uagb-tabs__body" aria-labelledby="uagb-tabs__tab2"><!-- wp:paragraph -->
<p><meta charset="utf-8">Content Tab 3</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:uagb/tabs-child --></div></div>
<!-- /wp:uagb/tabs -->

Thank you

Hi @joeleem0n, what is your take on this?

I’ve changed the function get_geoip_data() in the file public/class-warehouse-popups-woocommerce-public.php

to this:

function get_geoip_data(){

        if (is_admin()) {
            return false;
        }
        if (function_exists('geoip_detect2_get_info_from_current_ip')) {
                        $geoInfo = geoip_detect2_get_info_from_current_ip();
                        $geo_country_code = $geoInfo->country->isoCode;
                        $geo_country_name = $geoInfo->country->name;

                        //ChromePhp::log("Country name: $geo_country_name, country code: $geo_country_code");
                        $obj['name'] = $geo_country_name;
                        $obj['alpha2'] = $geo_country_code;
                }
        else {
                $ip = self::get_client_ip();
                $cache_data = self::_wmw_get_data_from_cache( $ip );

                if( $cache_data ){
                        $obj = json_decode( $cache_data, true );
                }else{
                        $geoip_url      = "https://api.ipgeolocationapi.com/geolocate/" . $ip;
                        $json           = self::curl_get_contents($geoip_url);
                        $obj            = json_decode( $json, true );

                        self::_wmw_add_data_to_cache( $json, $ip );
                }
        }
        //ChromePhp::log("obj value:");
        //ChromePhp::log($obj);

        $return_arr = array(
            'name'                      => $obj['name'],
            'country_code1' => $obj['alpha2'],
            'country_code2' => $obj['alpha3']
        );

        return $return_arr;
    }

and now $obj is correctly populated and the function is called 16 times instead of 900 times.

Also avoiding the api.ipgeolocationapi.com which is responsible of all the slowdown of the site

Dear @joeleem0n,

As I have a site with a lot of traffic I need to make sure these functions each time I’m updating the site; it’s a bit frustrating but it’s also a constructive approach in making this plugin more mature and stable, I hope you appreciate this.

I saw that now you implement an internal cache for each IP with the function get_geoip_data and then on auto_warehouse_switch you just retrieve it from the cache:

1. I guess you get_geoip_data is always called before auto_warehouse_switch ?
2. get_geoip_data has been reverted in fetching the geolocation from https://api.ipgeolocationapi.com/geolocate/ for the first request and then adds it to its cache, this is a problem as if you receive a lot of requests from different new IPs you’ll have the same issue as mentioned at the beginning of the thread where New Relics identified 30-40sec of response time. I’m proposing a little change below that is getting tested.

I understand that you don’t want to depend on another module even if it enables you to cover multiple services (CDNs, local databases, relevant APIs) and that already have caching systems in place… so what I’m proposing at this point is just this additional case in the if else of get_geoip_data function to support the “Geo ip detection” plugin:

function get_geoip_data(){
        if (is_admin()) {
            return false;
        }

                $ip = self::get_client_ip();
                $cache_data = self::_wmw_get_data_from_cache( $ip );

                if( $cache_data ){
                        $obj = json_decode( $cache_data, true );
                }else if (function_exists('geoip_detect2_get_info_from_current_ip')) {
                        $geoInfo = geoip_detect2_get_info_from_current_ip();
                        $geo_country_code = ($geoInfo->country->isoCode);
                }
                else{
                        $geoip_url      = "https://api.ipgeolocationapi.com/geolocate/" . $ip;
                        $json           = self::curl_get_contents($geoip_url);
                        $obj            = json_decode( $json, true );
                        
                        self::_wmw_add_data_to_cache( $json, $ip );
                }

        $return_arr = array(
            'name'                      => $obj['name'],
            'country_code1' => $obj['alpha2'],
            'country_code2' => $obj['alpha3']
        );

        return $return_arr;
    }

This just because using ipgeolocationapi has performance issues and should be left as a last resort.

You should also mention this in the Installation section of the plugin that using “Geo ip detection” is supported and might give them better performances.

Please let me know.
Best

• This reply was modified 5 years, 1 month ago by allanext.
• This reply was modified 5 years, 1 month ago by allanext.

Thank you @msaari !

we are def purchasing the pro version, also considering the indexing of epubs and pdfs. And you are correct; Pods are like ACF or Toolset for creating content types, but open source.

If I understand correctly the relevanssi_match hook is for filtering the results returned by the query (eventually setting the weight to 0 to not show them?), but wouldn’t it be better to add filters to the query like this ?

In this stackoverflow there’s a full example that can be very helpful at first when trying to understand how to integrate all the parts. The second answer.

Can the taxonomy filters be integrated in the relevanssi_modify_wp_query hook as well? From your link I don’t see how to integrate the extra taxonomy arguments in the WP_Query/searchform.php

Thanks again!

• This reply was modified 5 years, 4 months ago by allanext.
• This reply was modified 5 years, 4 months ago by allanext.

Hi @joeleem0n,

check the overall improvement between PHP, MySQL and the external service by just removing those 2 API calls and using GeoIp instead:

https://ibb.co/kHb6qbd

It’s quite impressive!