ace0930

@bcworkz I have created a menu page with a form, I want the user to go back to the menu page ( same place ) after submitting the form.

Sorry because I don’t understand how $_SERVER['REQUEST_URI'] will cause so many errors, can you elaborate more?

Or actually, do you have a better alternative for this? My ideal result is sending the user back to the place where they submit the form. This cannot be hardcoded and it should be dynamic.

@bcworkz Not sure if this is a bug, the below code won’t work:

$current_status = $wpdb -> get_var (
   $wpdb -> prepare (
      "SELECT !value! FROM %s WHERE !name! = %s", $table_name, $name
   )
);

But the below code work:

$current_status = $wpdb -> get_var (
   $wpdb -> prepare (
      "SELECT !value! FROM !$table_name! WHERE !name! = %s", $name
   )
);

P.S, I use ! to replace the backticks here. Notice the backtick around $table_name, not sure if it is needed but it works

@bcworkz You’re right and I should look at the doc 🙂

But the doc said: “Arguments may be passed as individual arguments to the method, or as a single array containing all arguments”

1) In your answer, there are two arguments, shouldn’t we use the array to contain the two arguments?
2) I store the table name in a constant, does it need with the backtick too? But how?

define ( 'table_name', 'wp_table_name' );

$wpdb -> prepare ( "SELECT !value! FROM " . table_name . " WHERE !name! = %s", $name )

3) Why use the sprintf()-like syntax? Variables in double quotes can be parsed within it in PHP already, why do we need sprintf to make placeholders and replace them with arguments? Very weird to me…

Ok, I didn’t release the double quotes. Only Variable are parsed within it but not Constant.

@hellofromtonya Appreciate your guideline! Thank you so much

@threadi Sorry because I misread plugin_basename( $file ) as basename(__FILE__)…

But I think you still misunderstood my point, I’m not comparing plugin_basename( $file ) with basename(__DIR__) . '/' . basename(__FILE__), of course the former is shorter.

I’m looking at what plugin_basename does and it’s so much longer than my code basename(__DIR__) . '/' . basename(__FILE__) if you look at the source.

Below is the full code of plugin_basename:

function plugin_basename( $file ) {
	global $wp_plugin_paths;

	// $wp_plugin_paths contains normalized paths.
	$file = wp_normalize_path( $file );

	arsort( $wp_plugin_paths );

	foreach ( $wp_plugin_paths as $dir => $realdir ) {
		if ( strpos( $file, $realdir ) === 0 ) {
			$file = $dir . substr( $file, strlen( $realdir ) );
		}
	}

	$plugin_dir    = wp_normalize_path( WP_PLUGIN_DIR );
	$mu_plugin_dir = wp_normalize_path( WPMU_PLUGIN_DIR );

	// Get relative path from plugins directory.
	$file = preg_replace( '#^' . preg_quote( $plugin_dir, '#' ) . '/|^' . preg_quote( $mu_plugin_dir, '#' ) . '/#', '', $file );
	$file = trim( $file, '/' );
	return $file;
}

So comparing the above code with my code basename(__DIR__) . '/' . basename(__FILE__), which one is shorter? LOL

@threadi You should look at the documentation ( https://developer.wordpress.org/reference/functions/register_activation_hook/ ).

The hook should be activate_sampleplugin/sample.php, and ‘plugin_basename(__FILE__)’ will return only the file name ( sample.php ) without the folder name ( sampleplugin ).

And that’s the question I was asking, why can’t I just use add_action( 'activate_' . basename(__DIR__) . '/' . basename(__FILE__), 'my_callback_function' ); instead of ‘register_activation_hook( __FILE__, ‘my_callback_function’ );’?

I have explained in detail that my suggestion is better because it is shorter.