wrong http url for twitter

  • Resolved gbirbilis

    (@gbirbilis)


    5 years, 3 months ago

    I see in wp-content\plugins\w3-total-cache\inc\lightbox the following:

    <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>

    this should be wrong since
    http://platform.twitter.com/widgets.js
    is broken url now (only https:// works)

    there is no problem using https:// from an http:// page, only the other way around is not allowed. So should tell lightbox guys (or fix it yourself too in there) to use https:// instead of that broken script

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Marko Vasiljevic

    (@vmarko)

    5 years, 3 months ago

    Hello @gbirbilis

    Thank you for the information.
    Let me double-check this and I’ll get back to you once done.
    Thanks!

    Thread Starter gbirbilis

    (@gbirbilis)

    5 years, 3 months ago

    looked at that error I was having with that url in browser tools and seems it was browser security or tracking prevention (edge chromium on Win10), and it was just coincidental that when I tried the http one on the browser address bar it wasn’t showing its content (now shows)

    I had located it in some places in our wordpress installation and changed everywhere to https, but tracking prevention still grabs it anyway

    however it’s better to use https:// to get such resources (even from inside http://) pages and most people suggest using that instead of // and instead of extracting and prepending the main page’s url protocol

    unless one also wants to support archaic clients that may not support https at all

    Plugin Contributor Marko Vasiljevic

    (@vmarko)

    5 years, 3 months ago

    Hello @gbirbilis

    Thank you for the information.
    The idea is that there are still users on HTTP. SO we meed to keep that in mind.
    Once again thank you for the information and your suggestion.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘wrong http url for twitter’ is closed to new replies.