Plugin Contributor
Ewout
(@pomegranate)
I believe you have posted to the wrong forum, this error is unrelated to the WooCommerce PDF Invoices & Packing Slips plugin.
But after disabling it, the error is gone mate. I’m currently searching the place where this error comes from.
For example the WooCommerce dashboard widget don’t works anymore when using the newest version. After disabling it, it works again.
Plugin Contributor
Ewout
(@pomegranate)
Is it possible that you have enabled the “Debug output” option under WooCommerce > PDF Invoices > Status? This can output errors from all plugins on your site and thus interfering with multiple processes. We do not utilize that particular JS function (nor have any changes been made in the JS parts of this plugin).
Nope, it’s disabled. I’m currently trying to roll back to the previous version.
Plugin Contributor
Ewout
(@pomegranate)
Hello Johannes,
If you can post your system status report (Woocommerce > Status > Get system report) we can see if there are any specific plugin conflicts. We don’t see this error in our testing environments and haven’t had any other reports yet so I think it’s a specific combination of plugins that triggers this error.
Plugin Contributor
Ewout
(@pomegranate)
p.s. there is one page on the plugin settings that was missing some woocommerce admin styles (fix commit here), this is scheduled for release tomorrow but if you want you could test the current dev version from github: https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips
Plugin Contributor
Ewout
(@pomegranate)
I just released this update (2.3.2), can you check whether this solves your issue?
Hey Ewout,
thanks. My error is solved. But I’ve found new ones:
wp-content/plugins/woocommerce-pdf-invoices-packing-slips/includes/compatibility/abstract-wc-data-compatibility.php line 119, 147, 172 & 195:
$object->id
Also wp-content/plugins/woocommerce-pdf-invoices-packing-slips/includes/compatibility/class-wc-product-compatibility.php line 47
The problem is that the member has a protected access here which might can cause issues. This shows up with an error in my IDE. So maybe you can find a better solution here.
Plugin Contributor
Ewout
(@pomegranate)
The files you are referencing are the compatibility classes to support old versions of WooCommerce, and these properties are only invoked for pre-3.0 woocommerce (as you can see by the version check here). This is because in WC2.X there were no property getters yet and this was the only way to access them. Can you give the full error/stacktrace that lead you to these functions?
Can you also tell us how you solved the original issue, in case someone else runs into this too?
The only thing that get’s displayed is “Member has protected access”. But I’m understanding now why you do this. Maybe there is a better way to do this. But if it works from your side with older version, there will be no problem I think.
Because of the previous issue: I’ve did a cherry pick from my branch back to the code before the update and updated your currently new version. Since this, everything looks fine.
Plugin Contributor
Ewout
(@pomegranate)
Is that message “Member has protected access” displayed in your IDE or as an error in PHP? If it’s just your IDE, then you can ignore it, because it’s a false positive. Whether that member has protected access depends on the version of WooCommerce that is used and this is exactly what we check before accessing it. There is no ‘better way to do this’ because this is how that worked in older versions 🙂
Glad to hear you were able to resolve the initial issue too – if I understand correctly the error was triggered by code in your own branch rather than the official release?
