Blog page

  • Resolved vladff

    (@vladff)


    11 years, 3 months ago

    Hey guys,

    Just started building a theme around your plugin and I love how easily everything can be changed from inside the theme.

    I do have one problem with your RH_Query class which throws some errors on the blog page (I have a static front page/blog page setup): http://snag.gy/cNBmt.jpg. In case it helps, only customizations I have so far are overwriting meta.php and adding my own before/after content wrappers from inside the theme.

    If I overwrite the RH_Query class from the theme and leave it empty the errors go away and it doesn’t seem that anything else is affected.

    PS: There’s also an undefined index error for the quantity variable in single\ingredients.php

    Regards,
    Vlad

    https://wordpress.org/plugins/recipe-hero/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Captain Theme

    (@captaintheme)

    11 years, 3 months ago

    Hey Vlad,

    Awesome to hear you’re enjoying it! 🙂 If you need any other hooks / filters / etc. please let me know on GitHub.

    Looking into both issues now. It’s probably a bug on my end as the RH_Query class was just introduced in 1.0.0 and needs some work.

    Will get back to you here in a bit.

    Plugin Author Captain Theme

    (@captaintheme)

    11 years, 3 months ago

    Please try update to 1.0.3. Both should be fixed 🙂

    Thread Starter vladff

    (@vladff)

    11 years, 3 months ago

    Great, those are solved, thanks.

    But still, other things are happening (at least for me with WP 4.1) when the Recipe Page is not set from the settings:

    – Trying to get property of non-object for lines 128-132 in the same RH_Query file. I solved this by adding a check for $recipe_page on line 110;
    – Nothing Found message on all my existing pages. Switching from a static front page to latest posts solves this.
    Both these issues are fixed after I set a Recipe Page from the plugin’s settings.

    Thread Starter vladff

    (@vladff)

    11 years, 3 months ago

    So I wrapped everything inside your pre_get_posts function on line 50 from class-rh-query.php in this: if ( get_option( 'recipe_hero_recipes_page_id' ) ) { and the issues are gone. Though I don’t know if it’s the best way to handle it.

    Plugin Author Captain Theme

    (@captaintheme)

    11 years, 3 months ago

    Actually that may be the best fix. Looking into it more now. Sorry, didn’t catch them on my side before, but thanks for working with me on this 🙂

    Plugin Author Captain Theme

    (@captaintheme)

    11 years, 3 months ago

    Hey Vlad – would you mind trying out this version and letting me know if it’s better? https://github.com/Recipe-Hero/Recipe-Hero/archive/master.zip

    If so I’ll push the update. 🙂

    Thread Starter vladff

    (@vladff)

    11 years, 3 months ago

    Yeap, everything looks fine, thanks.

    Plugin Author Captain Theme

    (@captaintheme)

    11 years, 3 months ago

    Thanks for checking 🙂 If you find anything else not working, etc. feel free to let me know here or on GitHub. Thanks for using Recipe Hero!

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Blog page’ is closed to new replies.