ID attribute in shortcode should use double-quotes, not single-quotes

  • Resolved vahost

    (@vahost)


    8 years, 9 months ago

    Best practices suggest that the Shortcode / Preview box in the top-right corner of the slider’s editing page where the user can copy the code to their clipboard with a single click should surround the ID number of the slider with double-quotes, not single quotes. If the shortcode needs to be nested within another element (such as with javascript or PHP) the nested single quotes currently used will interfere with single quotes used in the javascript or PHP script.

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author simonpedge

    (@simonpedge)

    8 years, 9 months ago

    Depends on whether you use single or double quotes within your PHP/JavaScript. This is like the ‘Tabs V Spaces’ debate.

    I fall on the side of using single quotes for PHP/JS (and tabs within code!) so I will amend this for the next release of Slide Anything.

    Plugin Author simonpedge

    (@simonpedge)

    8 years, 9 months ago

    Ok, I have implemented this change in the next version of Slide Anything.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘ID attribute in shortcode should use double-quotes, not single-quotes’ is closed to new replies.