PHP version check on 1.16.3 incorrectly triggering

  • Resolved David E. Smith

    (@desmith)


    8 years, 11 months ago

    My team and I are using this plugin on a couple of sites, running on Red Hat servers. RHEL6, which comes with PHP 5.3.3 (plus back-ported bug fixes and such). Unfortunately, on those servers, the version check is incorrectly triggering, and saying I need to upgrade to 5.3.3 or later.

    Maybe there’s an edge case in however you’re comparing versions that doesn’t behave if the versions match exactly? (Wild speculation from a non-programmer.) Anything I can do to help you troubleshoot what might be going on?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Craig Hewitt

    (@podcastmotor)

    8 years, 11 months ago

    Hi David,

    Sorry for the trouble that this is causing you. Indeed I would think this is an edge case because we have tested the plugin out on PHP 5.3.3, but this is something we’ll look into and see what kind of resolution we can provide.

    Out of curiosity is there anything about your sites that are restricting you from updating PHP versions?

    Craig

    Thread Starter David E. Smith

    (@desmith)

    8 years, 11 months ago

    There’s likely nothing inherent to any of our sites that would make them suddenly stop working if PHP were upgraded, but there’s no clear, vendor-supported path for such an upgrade. In our case, the vendor is Red Hat; RHEL 6 ships with PHP 5.3.3, plus back-ported security and bug fixes.

    [davsmi@wuis7843 ~]$ php --version
    PHP 5.3.3 (cli) (built: Nov 7 2016 11:21:30)
    Copyright (c) 1997-2010 The PHP Group
    Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies

    Thread Starter David E. Smith

    (@desmith)

    8 years, 11 months ago

    Looks like a simple enough fix. I modified the version check (line 23 of seriously-simple-podcasting.php) to use < instead of <= in the version_compare call. I assume your intent is that 5.3.3 is allowed, but 5.3.2 (and below) are not; you were excluding 5.3.3.

    If your intent was that the user must be running 5.3.4 or greater, and 5.3.3 is not supported, then you may want to update the comments in that file to match.

    Plugin Author Craig Hewitt

    (@podcastmotor)

    8 years, 10 months ago

    Hi David,

    Thanks for the update. We’ll take a look and include this in our next release.

    Cheers,
    Craig

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘PHP version check on 1.16.3 incorrectly triggering’ is closed to new replies.