Apostrophes

  • Resolved Dave

    (@csn123)


    9 years, 2 months ago

    I have noticed an issue since the last update. Any file with an apostrophes (e.g. fred’s boots) used to be renamed with a hyphen but no longer is.

    For example, “fred’s boots” would have become “freds-boots” but now is renamed “fredsboots”.

    Is this a permanent change, as the plugin is asking me to rename all my pretty files (e.g. “freds-boots”) in the newer, uglier format (e.g. “fredsboots”). I don’t want to rename all my old files if this is a bug.

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Jordy Meow

    (@tigroumeow)

    9 years, 2 months ago

    Mmm, this apostrophe is often an issue, in both cases, for different cases. What I will do is that I will rename the apostrophe into an hyphen, that’s simpler and works with all.

    Thread Starter Dave

    (@csn123)

    9 years, 2 months ago

    Great! Either a hyphen or an underscore should help with SEO 🙂

    Plugin Author Jordy Meow

    (@tigroumeow)

    9 years, 2 months ago

    Okay, I did, new version pushed 🙂

    Thread Starter Dave

    (@csn123)

    9 years, 2 months ago

    Thank you 🙂

    Plugin Author Jordy Meow

    (@tigroumeow)

    9 years, 2 months ago

    Is it working now?

    Thread Starter Dave

    (@csn123)

    9 years, 2 months ago

    Yes, thanks. I’ve renamed everything outstanding 🙂

    Plugin Author Jordy Meow

    (@tigroumeow)

    9 years, 2 months ago

    Ah, excellent news, I’m glad my last commit was a good one 🙂
    By the way, if you got some time, don’t hesitate to write a review for the plugin, even a tiny one always helps. Cheers ^^

    Ernest

    (@ersaloz)

    9 years, 2 months ago

    Problem is, this behavior is not consistent with WP core. E.g. if you upload a file

    l'aigua i l'estiu.jpg

    WP will rename it as

    laigua-i-lestiu.jpg

    while MFR will give

    l-aigua-i-l-estiu.jpg

    To be honest, I like best your approach, but departing from standards usually brings trouble, and I wonder if the benefit is worth the risk.

    Plugin Author Jordy Meow

    (@tigroumeow)

    9 years, 2 months ago

    I agree with you @ersaloz. However you can enable my option Rename on Upload and then it will be always my plugin “standard”. So I guess it’s alright. But I am not sure, would be great to hear many opinions about this 🙂

    Ernest

    (@ersaloz)

    9 years, 2 months ago

    But obviously it’s not the same thing to rename on upload (which I for one don’t care) than to autorename on title change (which I use a lot).

    Maybe a settings switch? Say ‘WP-base style’ vs ‘SEO style’ (?) (I don’t quite grasp the rationale behind, so just to illustrate).

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Apostrophes’ is closed to new replies.