We will check that, thanks for reporting.
Little bit of info:
I am using the dynamic_sidebar_params filter to add classes just like the Widget CSS Classes plugin.
Ok found the problem.
The filter widget_display_callback is called after dynamic_sidebar_params so when I do my logic the logic for this plugin hasn’t been done yet.
So basically the wrong instance of the widget is returned (example: widget_text instead of widget_2_text)
I could apply the widget_display_callback filter in my dynamic_sidebar_params hook but I have a strong feeling this could break other compatibilities… any thoughts are welcome.
Hi there.
Please try again with updated version and let me know if that works.
Notice: Trying to get property of non-object in ***/wp-content/plugins/wp-page-widget/wp-page-widgets.php on line 1303
Also checked the code. It could be that DB references change in time.
I wouldn’t go for a hard-coded solution.
I checked the functionality and usage of the widget_display_callback filter and it seems safe to use. Plus it will probably make it compatible with more plugins.
I’ll release an update for this asap (after testing a bit more)
Hi Jory.
Which solution hard-coded did you mention? We are looking forward to see your update.
Hi ntsasng,
I mean the whole sidebar_params function you’ve added for compat. If anything changes this compat change won’t work anymore.
I’ve added the widget_display_callback to my latest dev.
If you can find the time, could you test this for your environment aswell?
For me this works like a charm.
https://github.com/JoryHogeveen/genesis-widget-column-classes/tree/dev
Specific commit:
https://github.com/JoryHogeveen/genesis-widget-column-classes/pull/2/commits/461e6463a05400bf028b1574393aaeada1f901c7
Let me know!
Hi @ntsasng and @codeandmore,
Version 1.2 is compatible with your plugin.
https://wordpress.org/plugins/genesis-widget-column-classes/changelog/
It applies the widget_display_callback filter in the sidebar_params hook.
Thanks Jory, please check with the latest version of our plugin to see if they are still compatible. Thanks!
