media images will not insert

Please follow the steps here
https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages

If it used to work, you’ve done it before, and then suddenly it stopped working properly, there might be some plugin conflict. Try deactivate some plugin that you activated recently.