Custom post types: Settings are not properly respected (with patch!)
-
Hi plugin devs,
I’m working on a client’s site where we had the Shariff plugin not properly ignoring custom post types and therefore slowing performance (generating more http request to backend).
I investigated and found that for us the “should shariff insert itself after this post?” logic did not seem to be working. So I fixed it. Sending you the patch here so you can investigate for yourselves and hopefully incorporate a fix for everyone.
https://gist.github.com/seeekr/558d0d81154d24851abb
(I’m not super experienced in WP development, so I might be misunderstanding something going on here, and if so, please let me know and/or adjust the patch.)
Site where you can see the bug live in action:
https://www.testboks.com/vebu/If you open the network tab in the dev console and filter for “shariff” you’ll see a number of shariff backend requests being sent off for a number of testimonial custom post items on the page. We have definitely disabled shariff for that post type through shariff’s settings.
(The patch I’ve linked to is not live yet on that site, but only in my private dev env.)Cheers,
Denis
The topic ‘Custom post types: Settings are not properly respected (with patch!)’ is closed to new replies.