Hi rmast,
I have installed slideshow version 2.3.1 on a site to test and it seems to work fine. I think there is a conflict somewhere else. Any chance you can shoot me a link to your site thats broken? If you can turn on MMR that would be ideal to help me debug it.
Also, it might be worth trying turning off the minification in MMR.
Thread Starter
rmast
(@rmast)
I’ll try to publish a site-shadowcopy with a hosts-entry to a specific IP-adress soon.
Strange enough our other host, which I upgraded to 4.4 to reproduce the issue, doesn’t show it yet. Next weekend I’ll move the whole site to the other host and take the site with the issue off-line, so I can put MMR on again and give you an IP-address for a hosts-entry.
There is a difference between the hosts: The current host is a cheap host with varnish cache, €25,- ex. VAT a year, the other is a dedicated ispconfig3-host with my own installation of varnish cache of €15,- ex. VAT a month. I’m curious whether we’ll find some low level hosting-configuration-issue.
Thread Starter
rmast
(@rmast)
My (our) site is http://www.tekenbeetziekten.nl
I made a copy of the files and the database of wordpress back to the host that remarkably doesn’t show the issue between MMR 1.5.2 and slideshow 2.3.1.
Via an entry in the hosts file you can see an exact copy of the site which doesn’t show a picture quite in the middle of the site via slideshow 2.3.1. Instead you get some turning circle.
#pcextreme
109.72.85.5 tekenbeetziekten.nl http://www.tekenbeetziekten.nl
For some reason this forum puts http:// in front of the domain, you should delete that.
Thread Starter
rmast
(@rmast)
I did a diff between both home-pages, and there is a difference, the wrong one has .min.css at the end of the minified links and the right site only .css, so .min is missing. That’s probably a setting that somehow didn’t get copied well.
Thread Starter
rmast
(@rmast)
So your hypothesis is right.
Thread Starter
rmast
(@rmast)
Stupid question: How do I turn off minification? I only see options for turning off merging?
Thread Starter
rmast
(@rmast)
Probably this is a hint in the right direction:
◾Minifies JS with Google Closure (requires php exec) with fallback to Minify
My cheap hosting probably has php exec turned off by default, I’ll investigate that.
Thread Starter
rmast
(@rmast)
Turning on php exec doesn’t solve the issue, so I turned it off again…
Turning off minification only happens when the machine is not able to minify I presume?
Thread Starter
rmast
(@rmast)
Thread Starter
rmast
(@rmast)
For some reason the content of all.frontend.min.js doesn’t get executed whenever it is part of the merged and minified js, even when I completely copy the contents on top or on bottom of the minified file. It only gets executed when I put it as a separate entry above or below the minified script on the homepage, so order is not an issue, just being in or outside the minified file…
Thread Starter
rmast
(@rmast)
Found the minification error:
The new wordpress 4.4 wp-embed.min.js – script looses some ; right behind an else statement with the minification that is run without php exec. You could wonder whether this is a minification bug, a wordrpess 4.4 bug or a MMR bug. But it’s clearly a bug.
Thread Starter
rmast
(@rmast)
Ahh, that explains why I couldn’t replicate the issue.
It looks like PHP Minify has an issue with the way that wp-embed.min.js is minified. Actually, upon inspection of the minified wp-embed file it looks like there are some stray else statements.. that aren’t being used??? The un-minified versions don’t have these else statements.
If you do want to use wp-emebed.min.js you could possibly turn off minified javascript files using define( ‘SCRIPT_DEBUG’, true ); in your wp-config file. MMR should then minify it for you and hopefully without breaking anything.
Thread Starter
rmast
(@rmast)
As the file is already minified before MMR lays it’s hands on it (the only gain of minifying by MMR once more is dropping the two crucial semicolons) and your fear of some minification going wrong beforehand I would propose to minify the risk of minification by modify MMR to not minify any script with a name ending on .min.js.
How about that?
Thread Starter
rmast
(@rmast)
To reduce the calls to the minification without messing with the order of scripts you could somehow add the hash in the text in a way it wouldn’t be deleted, so you can afterward find back the hash and replace the .min.js with their originals.
