• Resolved Dan Knauss

    (@dpknauss)


    The shortcode — e.g. [listings columns=”3″] — generates the labels for listing attributes (beds, baths, square footage, etc.) in the markup well above the container and lists where it should appear.

    Tested with Twenty Fifteen, Twenty Twelve, and two commercial themes.

    I’ll post with more details @ github.

    https://wordpress.org/plugins/wp-listings/

Viewing 10 replies - 1 through 10 (of 10 total)
  • Thread Starter Dan Knauss

    (@dpknauss)

    I created a patch and made a pull request tonight simply changing the internationalization function from _e() to __() — the former echoes the (unwanted) text string for the field labels and the latter does not.

    I have the very same problem… I don’t understand how you created a patch. Please provide steps on how to fix this problem.

    thanks

    Anonymous User 7842110

    (@anonymized-7842110)

    I’m also having this issue after updating to 1.2

    The same problem after upgrading to 1.2

    Same issue here. Dan could you give me a little more detail about how you patched this? Which file are you making that change to? Thanks!

    Figured it out. Thanks Dan for the tip!

    What Dan is referring to is replacing _e() with __() before each output for Beds, Bath & Sq Ft.

    You can find this line of code in:

    /plugins/wp-listins/includes/shortcodes.php on line 106

    The replacement will look like this: (make sure to do it in all 3 places)

    _e( "Beds", 'wp_listings' )

    to

    __( "Beds", 'wp_listings' )

    Hope this helps. I’d imagine they will patch this pretty quickly since the company that built it manages real estate sites. They are probably starting to get blown up right about now.

    Thread Starter Dan Knauss

    (@dpknauss)

    Yes, that’s it Jordan. 🙂

    Dave Bonds, the plugin’s developer, just merged my commit, so he’ll probably be pushing out a new release soon.

    Guys, if you’re not familiar with github and these processes or the lingo, please click the link above and explore. Feel free to get in touch with me if you’re on the path to learning new things here — we all are — and I’ll be happy to offer what limited guidance I can.

    Anonymous User 7842110

    (@anonymized-7842110)

    Great, thanks guys. You’ve got my vote for most helpful and polite thread 😉

    Plugin Author agentevolution

    (@agentevolution)

    Fixed as of v1.2.1. Props to Dan!

    Thread Starter Dan Knauss

    (@dpknauss)

    Thanks! Glad to help a little.

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Broken shortcode output after 1.2 update’ is closed to new replies.