FIXED ERRORS

  • Resolved Robert_ITman

    (@robert_itman)


    12 years, 3 months ago

    Would be great if developer optimized the images and updated file simple-share-buttons-adder.php with the following to improve page speed and correct the errors on the page as reported by http://validator.w3.org

    FIXED ERRORS:
    (1) & did not start a character reference. (& probably should have been escaped as &)
    (2) Bad value for attribute href on element a: Whitespace in query component. Use %20 in place of spaces.
    (3) The center element is obsolete. Use CSS instead.

    FIXED simple-share-buttons-adder.php here is the fixed file:

    [ One thousand, two hundred and fifty four lines of code moderated, that’s just way too much. For that many lines of code please use pastebin.com instead. ]

    https://wordpress.org/plugins/simple-share-buttons-adder/

Viewing 9 replies - 1 through 9 (of 9 total)
  • susantau

    (@susantau)

    12 years, 1 month ago

    Yes! I completely agree!
    (and I know you meant to say that the ampersand should be escaped as [ampersand character]amp[semicolon character])
    PLUS, I would so like to see this plugin drop the use of Private Use Area Unicode.

    It’s a great plugin – but it could be even greater. 🙂
    Susan

    susantau

    (@susantau)

    12 years, 1 month ago

    Would love to see how you fixed those things…

    Thread Starter Robert_ITman

    (@robert_itman)

    12 years, 1 month ago

    The fix was here… but I can see it has been removed… I’ll try to find it and put it somewhere so you (and the developer) can use it.

    Thread Starter Robert_ITman

    (@robert_itman)

    12 years, 1 month ago

    Hope this helps… my code now passes validation. Update (plugin now at version 3.4) then edit the file /wp-content/plugins/simple-share-buttons-adder/simple-share-buttons-adder.php

    Replace:
    <center>
    With:
    <div style="text-align:center">

    Replace:
    </center>
    With:
    </div>

    …full fix is here: http://pastebin.com/PmmQzZgQ

    Optimize the images in /wp-content/plugins/simple-share-buttons-adder/buttons/

    Thread Starter Robert_ITman

    (@robert_itman)

    12 years, 1 month ago

    full file /wp-content/plugins/simple-share-buttons-adder/simple-share-buttons-adder.php

    as I updated it is here: http://pastebin.com/DZ7WRkj8

    susantau

    (@susantau)

    12 years, 1 month ago

    wow, thanks so much for providing this. Those errors have been driving me crazy.

    I really just don’t understand why SSBA doesn’t incorporate these few simple fixes to make their plug-in shinier. Meanwhile, we have to re-fix SSBA with any new update.

    Plugin Author Simple Share

    (@davidoffneal)

    12 years, 1 month ago

    Thanks for the suggestions and help sorting this. I have incorporated these into the latest release. Please let me know if I have missed anything.

    Thanks!

    susantau

    (@susantau)

    12 years, 1 month ago

    Wow, that’s excellent news!

    webmaster@mamse.org

    (@webmastermamseorg)

    12 years, 1 month ago

    Love the plug in. However, I’m having an issue with code showing up in addition to some of the buttons. Specifically, email, tumblr, stumblupon, and reddit. (you can see an example at my site)

    Would really love to see this fixed or resolved.

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘FIXED ERRORS’ is closed to new replies.