• Resolved bnourse

    (@bnourse)


    Nothing happens when clicking the edit link next to a form element. Firebug appears to show that necessary scriptaculous functions are not getting loaded.

    Sortable is not defined
    http://www.mysite.com/wp-content/plugins/wordpress-form-manager/js/scripts.js?ver=3.1.3
    Line 91
    function fm_initEditor(){
      Sortable.create('form-list',{handles:$$('a.handle')});
    }
    Effect is not defined
    http://www.mysite.com/wp-admin/admin.php?page=fm-edit-form&sec=design&id=2
    Line 43
    if(editClick.innerHTML == 'edit'){
     if(callback != "") eval(callback + '(itemID,false);');
     editClick.innerHTML = 'done';
     Effect.BlindDown(itemID + '-edit-div', { duration: 0.2 });
    }

    http://wordpress.org/extend/plugins/wordpress-form-manager/

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author hoffcamp

    (@hoffcamp)

    Hey, thanks for posting the firebug output. I was enqueueing ‘scriptaculous’, which I assumed included the effects. Turns out it doesn’t. I will release an update shortly.

    *EDIT Turns out ‘effects’ should be included. I’ll figure this out…

    Thread Starter bnourse

    (@bnourse)

    Awesome, thanks for the quick response.

    Plugin Author hoffcamp

    (@hoffcamp)

    Can you see which scripts are being loaded in your page source?

    Thread Starter bnourse

    (@bnourse)

    [Large code excerpt removed by moderator per forum rules. Please use the pastebin for all large code excerpts. It works better anyway.]

    Plugin Author hoffcamp

    (@hoffcamp)

    I just posted 1.5.1 which may fix your issue.

    Thread Starter bnourse

    (@bnourse)

    Not sure if it fixed the original issue, but there is a new issue:

    When clicking the “Form” menu:

    fm_registerSaveValidator is not defined
    http://www.mysite.com/wp-admin/admin.php?page=fm-edit-form&id=1
    Line 358

    And the following when clicking on a specific form:

    fm_initEditor is not defined
    http://www.mysite.com/wp-admin/admin.php?page=fm-edit-form&id=1
    Line 699
    
    and
    
    fm_registerExtraSaveVar is not defined
    http://www.mysite.com/wp-admin/admin.php?page=fm-edit-form&id=1
    Line 723

    The second one happening a total of 4 times trying to register different variables.

    On clicking an element type to add:

    fm_addItem is not defined
    http://www.mysite.com/wp-admin/admin.php?page=fm-edit-form&id=1
    Line 1

    I suppose I should add that I removed 1.5.0 by deactivating and then deleting through the plugin panel. Then checking to make sure the files were deleted from the webserver.

    Plugin Author hoffcamp

    (@hoffcamp)

    Okay… I am curious if the <link … > tags at the head of the generated code contain a link to my plugin’s script file and what other scripts are being loaded. Can you check this?

    Thread Starter bnourse

    (@bnourse)

    It looks like userscripts.js is loaded:

    <script type='text/javascript' src='http://www.mysite.com/wp-includes/js/l10n.js?ver=20101110'></script>
    <script type='text/javascript' src='http://www.mysite.com/wp-admin/load-scripts.php?c=1&load=jquery,utils&ver=7bb5fde83e0949a753f31e184d1c6ac7'></script>
    <script type='text/javascript' src='http://mysite.com/wp-content/plugins/the-events-calendar/resources/events.js?ver=3.1.3'></script>
    <script type='text/javascript' src='http://mysite.com/wp-content/plugins/wordpress-form-manager/js/userscripts.js?ver=3.1.3'></script>

    Plugin Author hoffcamp

    (@hoffcamp)

    It looks like the admin_init action is not firing. There is also supposed to be a ‘scripts.js’ loaded, which are admin specific scripts for the editors. If you remove and re-download the plugin, I have made a small change that may fix the problem.

    Thread Starter bnourse

    (@bnourse)

    It appears to be some sort of conflict with the “WP e-commerce” plugin. (their site w/download: http://getshopped.org/)

    I initially discounted it, as I still can’t find any evidence it’s making changes to the generated settings page, but when it’s disabled I am able to add/remove/edit/save forms and components without issue. Enabling it causes the functionality to disappear again. (generating the same errors as above that you indicated were occurring because scripts.js wasn’t loading) Possibly a naming conflict in init functions or with scripts.js itself?

    Plugin Author hoffcamp

    (@hoffcamp)

    The short answer is that on line 355 of wpsc-admin/admin.php (v3.8.4) we find:

    wp_deregister_script( 'prototype' );

    I don’t believe this is standard practice.

    The longer answer is that my scripts depend on ‘scriptaculous’, which depends on ‘prototype’. The removal of this library causes a “conflict” with my plugin.

    The quick and dirty solution would be to comment out line 355 of wpsc-admin/admin.php, as in, put “//” before it, or, add the following to the function bodies on lines 271 – 276 of wordpress-form-manager.php:

    wp_register_script( 'prototype', '/wp-includes/js/prototype.js', false, '1.6.1');
    wp_enqueue_script('prototype');
    wp_print_scripts();

    These are both ugly and force you to redo the hack every time you update, not good.

    I would lobby the people at WP-e-commerce to remove the prototype library only when the user is on their plugin’s admin pages, rather than for the whole admin site.

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘[Plugin: WordPress Form Manager] JS errors when editing form elements with 1.5.0’ is closed to new replies.