Bug: attribution links broken by missing quote (class-venomaps-plugin.php:718)

Hi Nicola,

We noticed VenoMaps’ attribution links resolve to broken URLs, and tracked it to a missing closing quote in the attribution builder.

In include/class-venomaps-plugin.php line 718 (v2.1.7):

php

$attribution .= ' <a href="' . $attrib['link'] . ' target="_blank">' . $attrib['title'] . '</a> |';

The href value parses as https://www.stadiamaps.com/ target= instead of the URL, so browsers resolve it to https://www.stadiamaps.com/%20target= — a 404. This affects every provider in the attribution array (Stadia Maps, Stamen, OpenMapTiles, OSM, Maptiler, Thunderforest), so all attribution links on all installs are currently dead.

Suggested fix:

php

$attribution .= ' <a href="' . esc_url( $attrib['link'] ) . '" target="_blank" rel="noopener">' . esc_html( $attrib['title'] ) . '</a> |';

(Added esc_url/esc_html and rel="noopener" while we’re in there, but the quote is the actual bug.)

Happy to help test. Thanks for building a privacy-friendly mapping plugin — we’re glad Stamen styles are in it.

Thanks!